summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2021-10-29 07:07:14 +0200
committerPatrick Georgi <pgeorgi@google.com>2021-11-03 08:22:05 +0000
commite4b2d7da4f8a0d292e194ca281d0c0978fa46606 (patch)
treec919bf8cd01b4158c0e8f44c5c62e86e22068932
parent5cd1871929735f2f05b4509afaa63e1def4f8f16 (diff)
downloadcoreboot-e4b2d7da4f8a0d292e194ca281d0c0978fa46606.tar.gz
coreboot-e4b2d7da4f8a0d292e194ca281d0c0978fa46606.tar.bz2
coreboot-e4b2d7da4f8a0d292e194ca281d0c0978fa46606.zip
mb/siemens/mc_ehl1: Adjust PCIe clock settings in devicetree
On mc_ehl1 there are three of the 6 PCIe clocks used to drive PCIe devices. None of the used clock output is dedicated to a special device (CLK0 drives several devices on the mainboard, CLK1 and CLK2 are connected to a PCIe switch). Therefore do not use a port mapping of the clocks to avoid a stopping clock once a device is missing and the matching root port is disabled. Instead set the mapping to 'PCIE_CLK_FREE' to have a free running clock. In addition, use the defined constant 'PCIE_CLK_NOTUSED' instead of the value 0xFF to disable the CLKREQ-feature and unused clocks. Change-Id: I2beea76ff8fefd79f476bef343d13495b45cdfcf Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58740 Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/siemens/mc_ehl/variants/mc_ehl1/devicetree.cb26
1 files changed, 13 insertions, 13 deletions
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/devicetree.cb
index f6ac8b705f8c..e96e654f8f93 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/devicetree.cb
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/devicetree.cb
@@ -53,19 +53,19 @@ chip soc/intel/elkhartlake
register "PcieRpEnable[3]" = "1"
register "PcieRpEnable[6]" = "1"
- register "PcieClkSrcUsage[0]" = "0x00"
- register "PcieClkSrcUsage[1]" = "0x01"
- register "PcieClkSrcUsage[2]" = "0x02"
- register "PcieClkSrcUsage[3]" = "0xFF"
- register "PcieClkSrcUsage[4]" = "0xFF"
- register "PcieClkSrcUsage[5]" = "0xFF"
-
- register "PcieClkSrcClkReq[0]" = "0xFF"
- register "PcieClkSrcClkReq[1]" = "0xFF"
- register "PcieClkSrcClkReq[2]" = "0xFF"
- register "PcieClkSrcClkReq[3]" = "0xFF"
- register "PcieClkSrcClkReq[4]" = "0xFF"
- register "PcieClkSrcClkReq[5]" = "0xFF"
+ register "PcieClkSrcUsage[0]" = "PCIE_CLK_FREE"
+ register "PcieClkSrcUsage[1]" = "PCIE_CLK_FREE"
+ register "PcieClkSrcUsage[2]" = "PCIE_CLK_FREE"
+ register "PcieClkSrcUsage[3]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcUsage[4]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcUsage[5]" = "PCIE_CLK_NOTUSED"
+
+ register "PcieClkSrcClkReq[0]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcClkReq[1]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcClkReq[2]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcClkReq[3]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcClkReq[4]" = "PCIE_CLK_NOTUSED"
+ register "PcieClkSrcClkReq[5]" = "PCIE_CLK_NOTUSED"
# Disable all L1 substates for PCIe root ports
register "PcieRpL1Substates[0]" = "L1_SS_DISABLED"