diff options
| author | Jason Glenesk <jason.glenesk@amd.com> | 2023-06-23 13:56:56 -0700 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2023-06-28 19:32:58 +0000 |
| commit | e6841610be829b8de5aea955a33a712d49a57b66 (patch) | |
| tree | 17b490d6f6104e14ad8e9ae91c902cd6db8d59a5 | |
| parent | a965fc5e75905ffa311db7669c5dcad7c6be7fb6 (diff) | |
| download | coreboot-e6841610be829b8de5aea955a33a712d49a57b66.tar.gz coreboot-e6841610be829b8de5aea955a33a712d49a57b66.tar.bz2 coreboot-e6841610be829b8de5aea955a33a712d49a57b66.zip | |
mb/google/skyrim/var/winterhold: Set system_configuration to 3 to avoid SMU call
Update system_configuration to 3 for 15W. Specification "FT6
Infrastructure Roadmap #57316" incorrectly lists system config index of
4 for 15W. Setting to 4 will cause an additional call to the SMU that is
not needed and will add boot delay. Both SMU and FSP interpret configs >
3 as 3.
BUG=b:267294958
TEST=Confirm extra message "Service Request 0x5F" not in log.
Change-Id: Ib12c73f95030625b52e26f86e932ee2aaa6ea522
Signed-off-by: Jason Glenesk <jason.glenesk@amd.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76096
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
| -rw-r--r-- | src/mainboard/google/skyrim/variants/winterhold/overridetree.cb | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index 57e2cab90ba7..490b415a7644 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -11,8 +11,10 @@ chip soc/amd/mendocino # Set DPTC multi-profile common parameters # Refer the spec "FT6 Infrastructure Roadmap"#57316 - # Set system_configuration to 4 for 15W - register "system_configuration" = "4" + # Set system_configuration to 3 for 15W. Spec lists 4 for 15W, + # however, setting to 3 will avoid an additional communication + # with the SMU and save boot time. + register "system_configuration" = "3" register "thermctl_limit_degreeC" = "97" register "stt_control" = "1" |