diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2022-03-08 13:40:01 -0700 |
|---|---|---|
| committer | Karthik Ramasubramanian <kramasub@google.com> | 2022-03-10 17:24:06 +0000 |
| commit | f63dd17bb1b7bc19e87008a7122db7d150d35c69 (patch) | |
| tree | 116d2da6c79a9642d223bf30fb1c4d84aecbbec9 | |
| parent | 54786fece8e3ae7169fa53c1c6564474e30fbf0d (diff) | |
| download | coreboot-f63dd17bb1b7bc19e87008a7122db7d150d35c69.tar.gz coreboot-f63dd17bb1b7bc19e87008a7122db7d150d35c69.tar.bz2 coreboot-f63dd17bb1b7bc19e87008a7122db7d150d35c69.zip | |
mb/google/guybrush: Enable DEBUG_SMI for non-serial firmware
In order to copy the PSP verstage logs into x86 cbmem, we need to enable
DEBUG_SMI. This will include the CBMEM console code in SMM. I only
enable DEBUG_SMI when UART is disabled because SMM doesn't currently
save/restore the UART registers. This will result in clearing the
interrupt enable bits and makes it so you can no longer use the TTY.
BUG=b:221231786, b:217968734
BRANCH=guybrush
TEST=Build serial and non serial firmware and verify DEBUG_SMI is set
correctly.
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I85a7933e8eb49ff920d00e43a494aaeab555ef3b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62670
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
| -rw-r--r-- | src/mainboard/google/guybrush/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index ecec68849a91..b2cba6ecabe9 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -13,6 +13,7 @@ config BOARD_SPECIFIC_OPTIONS select AMD_SOC_CONSOLE_UART select BOARD_ROMSIZE_KB_16384 select CONSOLE_CBMEM_DUMP_TO_UART if !CONSOLE_SERIAL + select DEBUG_SMI if !CONSOLE_SERIAL # TODO(b/217968734): Always enable select DISABLE_KEYBOARD_RESET_PIN select DISABLE_SPI_FLASH_ROM_SHARING select DRIVERS_ACPI_THERMAL_ZONE |