diff options
| author | Martin Roth <gaumless@gmail.com> | 2023-10-23 19:06:13 -0600 |
|---|---|---|
| committer | Shelley Chen <shchen@google.com> | 2023-10-27 17:20:09 +0000 |
| commit | face29cd50890e8f6647a2a7ec3e879989b86952 (patch) | |
| tree | 153a07fa2989f7e909be6589c21ab0fa7248a9cd | |
| parent | cc93db94351a0abb7ae4d8d3fd70209e31f830e1 (diff) | |
| download | coreboot-face29cd50890e8f6647a2a7ec3e879989b86952.tar.gz coreboot-face29cd50890e8f6647a2a7ec3e879989b86952.tar.bz2 coreboot-face29cd50890e8f6647a2a7ec3e879989b86952.zip | |
security/intel/stm: Remove check that can never be true
STM_RSC_MEM_DESC defines rws_attributes as 3 bits, which can't be
greater than 7.
Found-by: Coverity Scan #1430578
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I1efd007e96abd6d5d36f314752abfadffb0024d1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78619
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
| -rw-r--r-- | src/security/intel/stm/SmmStm.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 3371f02efe99..64a4877ed4b2 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -354,9 +354,6 @@ static bool validate_resource(STM_RSC *resource_list, uint32_t num_entries) if (resource->header.length != sizeof(STM_RSC_MEM_DESC)) return false; - - if (resource->mem.rwx_attributes > FULL_ACCS) - return false; break; case IO_RANGE: |