diff options
| author | Tristan Corrick <tristan@corrick.kiwi> | 2018-12-11 19:35:49 +1300 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-01-03 18:09:44 +0000 |
| commit | fff243461cf2a7676243ae4f51494736cdadfdf3 (patch) | |
| tree | ee3a8e1ae805fc97d9868e1fe018768b2b0fd017 | |
| parent | 7bcd062c01d55c6d2dc6ba03a6173463fb5a604e (diff) | |
| download | coreboot-fff243461cf2a7676243ae4f51494736cdadfdf3.tar.gz coreboot-fff243461cf2a7676243ae4f51494736cdadfdf3.tar.bz2 coreboot-fff243461cf2a7676243ae4f51494736cdadfdf3.zip | |
sb/intel/lynxpoint: Remove incomplete SATA ACPI code
The existing SATA ACPI code for Lynx Point implements some methods and
devices, but not completely. These methods are optional and only used in
IDE mode. The code was likely copied from bd82x6x, where it has since
been removed.
As a result, many remarks produced by iasl about unreferenced objects
are eliminated.
Tested on an ASRock H81M-HDS and an Acer C720. No issues with SATA
were observed.
Change-Id: I808a9dff7b9ba34239ffd95fa4cb9b39b10c4b62
Signed-off-by: Tristan Corrick <tristan@corrick.kiwi>
Reviewed-on: https://review.coreboot.org/c/30149
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/southbridge/intel/lynxpoint/acpi/sata.asl | 54 |
1 files changed, 2 insertions, 52 deletions
diff --git a/src/southbridge/intel/lynxpoint/acpi/sata.asl b/src/southbridge/intel/lynxpoint/acpi/sata.asl index 44ce576e71e1..5c5098b6d0d6 100644 --- a/src/southbridge/intel/lynxpoint/acpi/sata.asl +++ b/src/southbridge/intel/lynxpoint/acpi/sata.asl @@ -19,59 +19,9 @@ // Note: Some BIOSes put the S-ATA code into an SSDT to make it easily // pluggable +/* Legacy mode is not yet supported. */ + Device (SATA) { Name (_ADR, 0x001f0002) - - Device (PRID) - { - Name (_ADR, 0) - - // Get Timing Mode - Method (_GTM, 0, Serialized) - { - Name(PBUF, Buffer(20) { - 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, - 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, - 0x00,0x00,0x00,0x00 }) - - CreateDwordField (PBUF, 0, PIO0) - CreateDwordField (PBUF, 4, DMA0) - CreateDwordField (PBUF, 8, PIO1) - CreateDwordField (PBUF, 12, DMA1) - CreateDwordField (PBUF, 16, FLAG) - - // TODO fill return structure - - Return (PBUF) - } - - // Set Timing Mode - Method (_STM, 3) - { - CreateDwordField (Arg0, 0, PIO0) - CreateDwordField (Arg0, 4, DMA0) - CreateDwordField (Arg0, 8, PIO1) - CreateDwordField (Arg0, 12, DMA1) - CreateDwordField (Arg0, 16, FLAG) - - // TODO: Do the deed - } - - Device (DSK0) - { - Name (_ADR, 0) - // TODO: _RMV ? - // TODO: _GTF ? - } - - Device (DSK1) - { - Name (_ADR, 1) - - // TODO: _RMV ? - // TODO: _GTF ? - } - - } } |