diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-06-08 15:52:03 +0200 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2020-07-24 23:23:54 +0000 |
| commit | 464519769b4639fbec49410e95e4a7951d2c7b2a (patch) | |
| tree | 97ad8f7ae86e8c578599eb3ee871888bd1a3176b /Makefile.inc | |
| parent | 579e096ec81c6d7d920fb54abb21662489301ab0 (diff) | |
| download | coreboot-464519769b4639fbec49410e95e4a7951d2c7b2a.tar.gz coreboot-464519769b4639fbec49410e95e4a7951d2c7b2a.tar.bz2 coreboot-464519769b4639fbec49410e95e4a7951d2c7b2a.zip | |
assert.h: Do not use __FILE__ nor __LINE__ on timeless builds
When refactoring, one can move code around quite a bit while preserving
reproducibility, unless there is an assert-style macro somewhere... As
these macros use __FILE__ and __LINE__, just moving them is enough to
change the resulting binary, making timeless builds rather useless.
To improve reproducibility, do not use __FILE__ nor __LINE__ inside the
assert-style macros. Instead, use hardcoded values. Plus, mention that
timeless builds lack such information in place of the file name, so that
grepping for the printed string directs one towards this commit. And for
the immutable line number, we can use 404: line number not found :-)
Change-Id: Id42d7121b6864759c042f8e4e438ee77a8ac0b41
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42196
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'Makefile.inc')
| -rw-r--r-- | Makefile.inc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Makefile.inc b/Makefile.inc index 89bb3e423983..a51b73d36ba5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -411,6 +411,10 @@ CPPFLAGS_common += -include $(src)/commonlib/bsd/include/commonlib/bsd/compiler. CPPFLAGS_common += -I3rdparty CPPFLAGS_common += -D__BUILD_DIR__=\"$(obj)\" +ifeq ($(BUILD_TIMELESS),1) +CPPFLAGS_common += -D__TIMELESS__ +endif + ifeq ($(CONFIG_PCI_OPTION_ROM_RUN_YABEL)$(CONFIG_PCI_OPTION_ROM_RUN_REALMODE),y) CPPFLAGS_ramstage += -Isrc/device/oprom/include endif |