summaryrefslogtreecommitdiffstats
path: root/payloads/libpayload/drivers
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2023-08-25 13:07:58 +0200
committerFelix Held <felix-coreboot@felixheld.de>2023-09-07 13:33:39 +0000
commitc033ca0cb9347ced242652591e7874f3d94d0645 (patch)
tree430136d26b2ec1aa517767ca473a6986a7ae5011 /payloads/libpayload/drivers
parent15cb0d55275d8d2c3509d2f529daa754a4e7a74d (diff)
downloadcoreboot-c033ca0cb9347ced242652591e7874f3d94d0645.tar.gz
coreboot-c033ca0cb9347ced242652591e7874f3d94d0645.tar.bz2
coreboot-c033ca0cb9347ced242652591e7874f3d94d0645.zip
libpayload: Add after an if conditional on the next line
Clang warns about this. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Change-Id: I8bdd45a7ef47274b0253397fa8fd9409a70d2192 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77434 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin L Roth <gaumless@gmail.com>
Diffstat (limited to 'payloads/libpayload/drivers')
-rw-r--r--payloads/libpayload/drivers/usb/usbhid.c24
1 files changed, 16 insertions, 8 deletions
diff --git a/payloads/libpayload/drivers/usb/usbhid.c b/payloads/libpayload/drivers/usb/usbhid.c
index 4ada62a9d748..12177ef2fe97 100644
--- a/payloads/libpayload/drivers/usb/usbhid.c
+++ b/payloads/libpayload/drivers/usb/usbhid.c
@@ -265,14 +265,22 @@ usb_hid_process_keyboard_event(usbhid_inst_t *const inst,
modifiers = 0;
- if (current->modifiers & 0x01) /* Left-Ctrl */ modifiers |= KB_MOD_CTRL;
- if (current->modifiers & 0x02) /* Left-Shift */ modifiers |= KB_MOD_SHIFT;
- if (current->modifiers & 0x04) /* Left-Alt */ modifiers |= KB_MOD_ALT;
- if (current->modifiers & 0x08) /* Left-GUI */;
- if (current->modifiers & 0x10) /* Right-Ctrl */ modifiers |= KB_MOD_CTRL;
- if (current->modifiers & 0x20) /* Right-Shift */ modifiers |= KB_MOD_SHIFT;
- if (current->modifiers & 0x40) /* Right-AltGr */ modifiers |= KB_MOD_ALT;
- if (current->modifiers & 0x80) /* Right-GUI */;
+ if (current->modifiers & 0x01) /* Left-Ctrl */
+ modifiers |= KB_MOD_CTRL;
+ if (current->modifiers & 0x02) /* Left-Shift */
+ modifiers |= KB_MOD_SHIFT;
+ if (current->modifiers & 0x04) /* Left-Alt */
+ modifiers |= KB_MOD_ALT;
+ if (current->modifiers & 0x08) /* Left-GUI */
+ ;
+ if (current->modifiers & 0x10) /* Right-Ctrl */
+ modifiers |= KB_MOD_CTRL;
+ if (current->modifiers & 0x20) /* Right-Shift */
+ modifiers |= KB_MOD_SHIFT;
+ if (current->modifiers & 0x40) /* Right-AltGr */
+ modifiers |= KB_MOD_ALT;
+ if (current->modifiers & 0x80) /* Right-GUI */
+ ;
if ((current->modifiers & 0x05) && ((current->keys[0] == 0x4c) ||
(current->keys[0] == 0x63))) {