diff options
| author | Yi Chou <yich@google.com> | 2024-01-08 13:54:55 +0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2024-01-11 21:02:30 +0000 |
| commit | df327f4a88bcfd6bc5db8256698f9e293bb9e03f (patch) | |
| tree | f0cefdc8a956361bf2be1978e1042496ed587ecc /payloads | |
| parent | e34a1f98151be7a58aaa4f6ec83f9cdd0a803ea1 (diff) | |
| download | coreboot-df327f4a88bcfd6bc5db8256698f9e293bb9e03f.tar.gz coreboot-df327f4a88bcfd6bc5db8256698f9e293bb9e03f.tar.bz2 coreboot-df327f4a88bcfd6bc5db8256698f9e293bb9e03f.zip | |
libpayload: Move back the ttb_buffer section
Moving it into the .ttb_buffer section will accidentally set the LOAD
flag. So, move it back to .bss.ttb_buffer section to prevent the binary
size bloating.
BUG=b:248610274
TEST=Make sure the device is still bootable with this change.
BRANCH=none
Cq-Depend: chromium:5173448
Change-Id: I9bb08878dd4be01d9ed3f96933f774dd6296f76e
Signed-off-by: Yi Chou <yich@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79800
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'payloads')
| -rw-r--r-- | payloads/libpayload/arch/arm64/libpayload.ldscript | 2 | ||||
| -rw-r--r-- | payloads/libpayload/arch/arm64/mmu.c | 7 |
2 files changed, 5 insertions, 4 deletions
diff --git a/payloads/libpayload/arch/arm64/libpayload.ldscript b/payloads/libpayload/arch/arm64/libpayload.ldscript index c9881f7ec07e..4042e45055e8 100644 --- a/payloads/libpayload/arch/arm64/libpayload.ldscript +++ b/payloads/libpayload/arch/arm64/libpayload.ldscript @@ -62,8 +62,6 @@ SECTIONS } .bss : { - *(.ttb_buffer) - _bss = .; *(.sbss) *(.sbss.*) diff --git a/payloads/libpayload/arch/arm64/mmu.c b/payloads/libpayload/arch/arm64/mmu.c index 5865b1b9efa3..9fc227dc8b89 100644 --- a/payloads/libpayload/arch/arm64/mmu.c +++ b/payloads/libpayload/arch/arm64/mmu.c @@ -41,8 +41,11 @@ static unsigned int max_tables; static uint64_t *xlat_addr; static int free_idx; -static uint8_t ttb_buffer[TTB_DEFAULT_SIZE] __aligned(GRANULE_SIZE) - __attribute__((__section__(".ttb_buffer"))); + +/* We refer to this in the linker script for ChormeOS's depthcharge payload + * and to please not change the name without discussing with us. + * Please contact: jwerner@chromium.org or yich@chromium.org */ +static uint8_t ttb_buffer[TTB_DEFAULT_SIZE] __aligned(GRANULE_SIZE); static const char * const tag_to_string[] = { [TYPE_NORMAL_MEM] = "normal", |