summaryrefslogtreecommitdiffstats
path: root/src/acpi/acpigen_dsm.c
diff options
context:
space:
mode:
authorJakub Czapiga <jacz@semihalf.com>2021-02-19 11:44:22 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-22 11:21:55 +0000
commit61fcb7e9654634cfe0c8a7bf56581fb54d943bd8 (patch)
treeb65b1a743c85294bc37e1ca7fe8160eeab741073 /src/acpi/acpigen_dsm.c
parent7f4c30c1d5c16539faf564d38ebbc695bca8836a (diff)
downloadcoreboot-61fcb7e9654634cfe0c8a7bf56581fb54d943bd8.tar.gz
coreboot-61fcb7e9654634cfe0c8a7bf56581fb54d943bd8.tar.bz2
coreboot-61fcb7e9654634cfe0c8a7bf56581fb54d943bd8.zip
acpi/acpigen.h: Add more intuitive AML package closing functions
Until now every AML package had to be closed using acpigen_pop_len(). This commit introduces set of package closing functions corresponding with their opening function names. For example acpigen_write_if() opens if-statement package, acpigen_write_if_end() closes it. Now acpigen_write_else() closes previously opened acpigen_write_if(), so acpigen_pop_len() is not required before it. Signed-off-by: Jakub Czapiga <jacz@semihalf.com> Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd Reviewed-on: https://review.coreboot.org/c/coreboot/+/50910 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Lance Zhao Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/acpi/acpigen_dsm.c')
-rw-r--r--src/acpi/acpigen_dsm.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/acpi/acpigen_dsm.c b/src/acpi/acpigen_dsm.c
index fc53ddff4db3..734fbd5cfb06 100644
--- a/src/acpi/acpigen_dsm.c
+++ b/src/acpi/acpigen_dsm.c
@@ -22,7 +22,6 @@ static void i2c_hid_func0_cb(void *arg)
acpigen_write_if_lequal_op_int(LOCAL2_OP, 0x1);
/* Return (Buffer (One) { 0x3 }) */
acpigen_write_return_singleton_buffer(0x3);
- acpigen_pop_len(); /* Pop : If */
/* Else */
acpigen_write_else();
/* Return (Buffer (One) { 0x0 }) */