diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2024-02-06 16:43:10 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-02-07 20:32:40 +0000 |
| commit | 9c25a03fc350d6739398be9c121b2055e0af4b85 (patch) | |
| tree | 4066ca800c21f0c1d5905b93bdaa2b8b34002b62 /src/arch | |
| parent | 7608699a9edb7a0bbf6a2c2051fba2db781975c2 (diff) | |
| download | coreboot-9c25a03fc350d6739398be9c121b2055e0af4b85.tar.gz coreboot-9c25a03fc350d6739398be9c121b2055e0af4b85.tar.bz2 coreboot-9c25a03fc350d6739398be9c121b2055e0af4b85.zip | |
arch/x86/mpspec: reduce scope of smp_write_ioapic
smp_write_ioapic is only called from smp_write_ioapic_from_hw within the
same compilation unit, so reduce its scope by making it a static
function.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6a1bbfd50ae9d6c8ab18f478ae9bae3f8bf5e10d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80357
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/arch')
| -rw-r--r-- | src/arch/x86/include/arch/smp/mpspec.h | 2 | ||||
| -rw-r--r-- | src/arch/x86/mpspec.c | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/src/arch/x86/include/arch/smp/mpspec.h b/src/arch/x86/include/arch/smp/mpspec.h index 48e5732a4fb0..0b5ca4700230 100644 --- a/src/arch/x86/include/arch/smp/mpspec.h +++ b/src/arch/x86/include/arch/smp/mpspec.h @@ -225,8 +225,6 @@ void smp_write_processor(struct mp_config_table *mc, u8 cpuflag, u32 cpufeature, u32 featureflag); void smp_write_processors(struct mp_config_table *mc); -void smp_write_ioapic(struct mp_config_table *mc, - u8 id, u8 ver, void *apicaddr); /* Call smp_write_ioapic() and return IOAPIC ID field. */ u8 smp_write_ioapic_from_hw(struct mp_config_table *mc, void *apicaddr); diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index b8bdb098094f..ac3fc79ba9bf 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -206,7 +206,7 @@ static void smp_write_bus(struct mp_config_table *mc, * Entry Type, APIC ID, Version, * APIC Flags:EN, Address */ -void smp_write_ioapic(struct mp_config_table *mc, +static void smp_write_ioapic(struct mp_config_table *mc, u8 id, u8 ver, void *apicaddr) { struct mpc_config_ioapic *mpc; |