summaryrefslogtreecommitdiffstats
path: root/src/device/device.c
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2013-06-10 10:41:04 -0700
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-11-26 19:10:38 +0100
commitcb73a8410cb80c8ff86e3d860ac3c8ae458b19ac (patch)
tree1172582fd4fb0835597dfdccceb581113cd30b68 /src/device/device.c
parent8adf7a2c50dcb3a7f09b66c1f3918ab195d8c5ec (diff)
downloadcoreboot-cb73a8410cb80c8ff86e3d860ac3c8ae458b19ac.tar.gz
coreboot-cb73a8410cb80c8ff86e3d860ac3c8ae458b19ac.tar.bz2
coreboot-cb73a8410cb80c8ff86e3d860ac3c8ae458b19ac.zip
Clean up POST codes for Boot State machine
Now that there is a clearly defined boot state machine we can add some useful post codes to indicate the current point in the state machine by having it log a post code before the execution of each state. This removes the currently defined POST codes that were used by hardwaremain in favor of a new contiguous range that are defined for each boot state. The reason for this is that the existing codes are mostly used to indicate when something is done, which is confusing for actual debug because POST code debugging relies on knowing what is about to happen (to know what may be at fault) rather than what has just finished. One additonal change is added during device init step as this step often does the bulk of the work, and frequently logs POST codes itself. Therefore in order to keep better track of what device is being initialized POST_BS_DEV_INIT is logged before each device is initialized. interrupted boot with reset button and gathered the eventlog. Mosys has been extended to decode the well-known POST codes: 26 | 2013-06-10 10:32:48 | System boot | 120 27 | 2013-06-10 10:32:48 | Last post code in previous boot | 0x75 | Device Initialize 28 | 2013-06-10 10:32:48 | Extra info from previous boot | PCI | 00:16.0 29 | 2013-06-10 10:32:48 | Reset Button 30 | 2013-06-10 10:32:48 | System Reset Change-Id: Ida1e1129d274d28cbe8e49e4a01483e335a03d96 Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/58106 Reviewed-on: http://review.coreboot.org/4231 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'src/device/device.c')
-rw-r--r--src/device/device.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/device/device.c b/src/device/device.c
index dee797ed356f..8bde663076c8 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -1162,6 +1162,7 @@ static void init_link(struct bus *link)
struct bus *c_link;
for (dev = link->children; dev; dev = dev->sibling) {
+ post_code(POST_BS_DEV_INIT);
post_log_path(dev);
init_dev(dev);
}