diff options
| author | Ziang Wang <ziang.wang@intel.com> | 2023-05-29 15:53:56 +0800 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-05-31 18:52:39 +0000 |
| commit | a6df40ca436142d84e6ffc34246f543c1bcd19c2 (patch) | |
| tree | 2d3191d7a2112089b675187a1d5720f700c77885 /src/device | |
| parent | 23c40997b408ba94328fdf7b8f1c4325512f15d7 (diff) | |
| download | coreboot-a6df40ca436142d84e6ffc34246f543c1bcd19c2.tar.gz coreboot-a6df40ca436142d84e6ffc34246f543c1bcd19c2.tar.bz2 coreboot-a6df40ca436142d84e6ffc34246f543c1bcd19c2.zip | |
device/dram: Update RDIMM classification from RIMM to DIMM
Registered DIMM should be 'FORMFACTOR_DIMM' with 'DETAIL_REGISTERED'
instead of 'FORMFACTOR_RIMM', RIMM has been EOL for so many years.
Memory form factor info is now correct on 4th Gen Xeon server platform
with registered DIMM.
Signed-off-by: Ziang Wang <ziang.wang@intel.com>
Signed-off-by: Kehong Chen <kehong.chen@intel.com>
Change-Id: I1eea4717a2d60c6100c262a2284a2ac5109f114a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75489
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Diffstat (limited to 'src/device')
| -rw-r--r-- | src/device/dram/spd.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/device/dram/spd.c b/src/device/dram/spd.c index 564a4ead921b..4a1e8825430c 100644 --- a/src/device/dram/spd.c +++ b/src/device/dram/spd.c @@ -57,7 +57,7 @@ static void convert_ddr2_module_type_to_spd_info(enum spd_dimm_type_ddr2 module_ switch (module_type) { case SPD_DDR2_DIMM_TYPE_RDIMM: case SPD_DDR2_DIMM_TYPE_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case SPD_DDR2_DIMM_TYPE_UDIMM: @@ -85,7 +85,7 @@ static void convert_ddr3_module_type_to_spd_info(enum spd_dimm_type_ddr3 module_ switch (module_type) { case SPD_DDR3_DIMM_TYPE_RDIMM: case SPD_DDR3_DIMM_TYPE_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case SPD_DDR3_DIMM_TYPE_UDIMM: @@ -114,7 +114,7 @@ static void convert_ddr4_module_type_to_spd_info(enum ddr4_module_type module_ty switch (module_type) { case DDR4_SPD_RDIMM: case DDR4_SPD_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case DDR4_SPD_UDIMM: @@ -139,7 +139,7 @@ static void convert_ddr5_module_type_to_spd_info(enum ddr5_module_type module_ty switch (module_type) { case DDR5_SPD_RDIMM: case DDR5_SPD_MINI_RDIMM: - info->form_factor = MEMORY_FORMFACTOR_RIMM; + info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; case DDR5_SPD_UDIMM: |