diff options
| author | Julius Werner <jwerner@chromium.org> | 2021-04-16 16:48:32 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2021-04-21 02:06:26 +0000 |
| commit | c893197352acc9b53c1beef5082cbc0271f63688 (patch) | |
| tree | b975712387bd54bd0101a736adbb2a6fe5b824bb /src/drivers/elog | |
| parent | b03e497ef16e9e38ba9220d31131a6bfdef35390 (diff) | |
| download | coreboot-c893197352acc9b53c1beef5082cbc0271f63688.tar.gz coreboot-c893197352acc9b53c1beef5082cbc0271f63688.tar.bz2 coreboot-c893197352acc9b53c1beef5082cbc0271f63688.zip | |
commonlib/region: Turn addrspace_32bit into a more official API
We had the addrspace_32bit rdev in prog_loaders.c for a while to help
represent memory ranges as an rdev, and we've found it useful for a
couple of things that have nothing to do with program loading. This
patch moves the concept straight into commonlib/region.c so it is no
longer anchored in such a weird place, and easier to use in unit tests.
Also expand the concept to the whole address space (there's no real need
to restrict it to 32 bits in 64-bit environments) and introduce an
rdev_chain_mem() helper function to make it a bit easier to use. Replace
some direct uses of struct mem_region_device with this new API where it
seems to make sense.
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ie4c763b77f77d227768556a9528681d771a08dca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52533
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/drivers/elog')
| -rw-r--r-- | src/drivers/elog/elog.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 82df989e25dc..4769559ca0be 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -44,7 +44,7 @@ struct elog_state { struct region_device nv_dev; /* Device that mirrors the eventlog in memory. */ - struct mem_region_device mirror_dev; + struct region_device mirror_dev; enum elog_init_state elog_initialized; }; @@ -56,7 +56,7 @@ static uint8_t elog_mirror_buf[ELOG_SIZE]; static inline struct region_device *mirror_dev_get(void) { - return &elog_state.mirror_dev.rdev; + return &elog_state.mirror_dev; } static size_t elog_events_start(void) @@ -798,8 +798,7 @@ int elog_init(void) printk(BIOS_ERR, "ELOG: Unable to allocate backing store\n"); return -1; } - mem_region_device_rw_init(&elog_state.mirror_dev, mirror_buffer, - elog_size); + rdev_chain_mem_rw(&elog_state.mirror_dev, mirror_buffer, elog_size); /* * Mark as initialized to allow elog_init() to be called and deemed |