diff options
| author | Julius Werner <jwerner@chromium.org> | 2016-04-06 12:50:40 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2016-04-07 20:46:38 +0200 |
| commit | 2b6db9738ef6d09a068b65ef472c2d54f99abc37 (patch) | |
| tree | ab43af5cac7b2d75fbb65705b2c43d1db0e45eca /src/drivers/emulation | |
| parent | 2268e0dc15d076c61792b97e954cad3f7c5f8c00 (diff) | |
| download | coreboot-2b6db9738ef6d09a068b65ef472c2d54f99abc37.tar.gz coreboot-2b6db9738ef6d09a068b65ef472c2d54f99abc37.tar.bz2 coreboot-2b6db9738ef6d09a068b65ef472c2d54f99abc37.zip | |
edid: Make framebuffer row alignment configurable
Our EDID code had always been aligning the framebuffer's
bytes_per_line (and x_resolution dependent on that) to 64. It turns out
that this is a controller-dependent parameter that seems to only really
be necessary for Intel chipsets, and commit 6911219cc (edid: Add helper
function to calculate bits-per-pixel dependent values) probably actually
broke this for some other controllers by applying the alignment too
widely.
This patch makes it explicitly configurable and depends the default on
ARCH_X86 (which seems to be the simplest and least intrusive way to make
it fit most cases for now... boards where this doesn't apply can still
override it manually by calling edid_set_framebuffer_bits_per_pixel()
again).
Change-Id: I1c565a72826fc5ddfbb1ae4a5db5e9063b761455
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/14267
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/drivers/emulation')
| -rw-r--r-- | src/drivers/emulation/qemu/bochs.c | 2 | ||||
| -rw-r--r-- | src/drivers/emulation/qemu/cirrus.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c index f32fee008cdc..74a72471a7cf 100644 --- a/src/drivers/emulation/qemu/bochs.c +++ b/src/drivers/emulation/qemu/bochs.c @@ -113,7 +113,7 @@ static void bochs_init(struct device *dev) edid.mode.va = height; edid.panel_bits_per_color = 8; edid.panel_bits_per_pixel = 24; - edid_set_framebuffer_bits_per_pixel(&edid, 32); + edid_set_framebuffer_bits_per_pixel(&edid, 32, 0); set_vbe_mode_info_valid(&edid, addr); #else vga_misc_write(0x1); diff --git a/src/drivers/emulation/qemu/cirrus.c b/src/drivers/emulation/qemu/cirrus.c index 84c2958031ae..dc20f540ae66 100644 --- a/src/drivers/emulation/qemu/cirrus.c +++ b/src/drivers/emulation/qemu/cirrus.c @@ -332,7 +332,7 @@ static void cirrus_init(struct device *dev) edid.mode.va = height; edid.panel_bits_per_color = 8; edid.panel_bits_per_pixel = 24; - edid_set_framebuffer_bits_per_pixel(&edid, 32); + edid_set_framebuffer_bits_per_pixel(&edid, 32, 0); set_vbe_mode_info_valid(&edid, addr); #else vga_misc_write(0x1); |