diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-10-03 16:29:12 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2020-10-11 02:13:33 +0000 |
| commit | 59a863e14ad366fa8e5f46cb506fc88c35ac8911 (patch) | |
| tree | d53413e2b69cd10fbb032a3ea2fa71103aa6e3f3 /src/drivers/intel | |
| parent | 494f319be78dc08c72d58cdd94bf09213b48238c (diff) | |
| download | coreboot-59a863e14ad366fa8e5f46cb506fc88c35ac8911.tar.gz coreboot-59a863e14ad366fa8e5f46cb506fc88c35ac8911.tar.bz2 coreboot-59a863e14ad366fa8e5f46cb506fc88c35ac8911.zip | |
drivers/intel/wifi: Use newly added pci_dev_is_wake_source
This change uses the newly added `pci_dev_is_wake_source()` helper function
to determine and log WiFi wake source instead of assuming a hard-coded
register value to check. This is done in preparation to merge the
generic WiFi and Intel WiFi drivers in coreboot in follow-up changes.
BUG=b:169802515
BRANCH=zork
Change-Id: I9bdb453092b4ce7bdab2969f13e0c0aa8166dc0a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46031
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers/intel')
| -rw-r--r-- | src/drivers/intel/wifi/wifi.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index e117ec0af7d1..cc58ac6187d7 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -10,9 +10,6 @@ #include "chip.h" #include "drivers/wifi/generic/chip.h" -#define PMCS_DR 0xcc -#define PME_STS (1 << 15) - #if CONFIG(GENERATE_SMBIOS_TABLES) static int smbios_write_wifi(struct device *dev, int *handle, unsigned long *current) @@ -63,12 +60,8 @@ static void intel_wifi_fill_ssdt(const struct device *dev) static void wifi_pci_dev_init(struct device *dev) { - if (CONFIG(ELOG)) { - uint32_t val; - val = pci_read_config16(dev, PMCS_DR); - if (val & PME_STS) - elog_add_event_wake(ELOG_WAKE_SOURCE_PME_WIFI, 0); - } + if (pci_dev_is_wake_source(dev)) + elog_add_event_wake(ELOG_WAKE_SOURCE_PME_WIFI, 0); } struct device_operations device_ops = { |