summaryrefslogtreecommitdiffstats
path: root/src/drivers/intel
diff options
context:
space:
mode:
authorNicholas Sudsgaard <devel+coreboot@nsudsgaard.com>2024-01-30 09:53:46 +0900
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2024-01-31 09:51:58 +0000
commitbfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch)
tree0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/drivers/intel
parentf4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff)
downloadcoreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.tar.gz
coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.tar.bz2
coreboot-bfb11bec3b3fec638adf864a9b9b2cff6671fed8.zip
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/drivers/intel')
-rw-r--r--src/drivers/intel/dptf/dptf.c2
-rw-r--r--src/drivers/intel/ish/ish.c2
-rw-r--r--src/drivers/intel/mipi_camera/camera.c2
-rw-r--r--src/drivers/intel/pmc_mux/conn/conn.c2
-rw-r--r--src/drivers/intel/pmc_mux/mux.c2
-rw-r--r--src/drivers/intel/soundwire/soundwire.c2
-rw-r--r--src/drivers/intel/usb4/retimer/retimer.c2
7 files changed, 7 insertions, 7 deletions
diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c
index 71a4ec340d6e..bceb0dea4a3f 100644
--- a/src/drivers/intel/dptf/dptf.c
+++ b/src/drivers/intel/dptf/dptf.c
@@ -636,6 +636,6 @@ static void dptf_enable_dev(struct device *dev)
}
struct chip_operations drivers_intel_dptf_ops = {
- CHIP_NAME("Intel DPTF")
+ .name = "Intel DPTF",
.enable_dev = dptf_enable_dev,
};
diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c
index 97116320be03..6dba46adc71d 100644
--- a/src/drivers/intel/ish/ish.c
+++ b/src/drivers/intel/ish/ish.c
@@ -97,6 +97,6 @@ static const struct pci_driver ish_intel_driver __pci_driver = {
};
struct chip_operations drivers_intel_ish_ops = {
- CHIP_NAME("Intel ISH Chip")
+ .name = "Intel ISH Chip",
.enable_dev = intel_ish_enable,
};
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 00c85a7010ca..77c86eaeb648 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -1033,6 +1033,6 @@ static void camera_enable(struct device *dev)
}
struct chip_operations drivers_intel_mipi_camera_ops = {
- CHIP_NAME("Intel MIPI Camera Device")
+ .name = "Intel MIPI Camera Device",
.enable_dev = camera_enable
};
diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c
index de8f2be30639..c2c719991be8 100644
--- a/src/drivers/intel/pmc_mux/conn/conn.c
+++ b/src/drivers/intel/pmc_mux/conn/conn.c
@@ -153,7 +153,7 @@ static void conn_enable(struct device *dev)
}
struct chip_operations drivers_intel_pmc_mux_conn_ops = {
- CHIP_NAME("Intel PMC MUX CONN Driver")
+ .name = "Intel PMC MUX CONN Driver",
.enable_dev = conn_enable,
};
diff --git a/src/drivers/intel/pmc_mux/mux.c b/src/drivers/intel/pmc_mux/mux.c
index e2099152a651..64669f67a50d 100644
--- a/src/drivers/intel/pmc_mux/mux.c
+++ b/src/drivers/intel/pmc_mux/mux.c
@@ -43,6 +43,6 @@ static void mux_enable(struct device *dev)
}
struct chip_operations drivers_intel_pmc_mux_ops = {
- CHIP_NAME("Intel PMC MUX Driver")
+ .name = "Intel PMC MUX Driver",
.enable_dev = mux_enable,
};
diff --git a/src/drivers/intel/soundwire/soundwire.c b/src/drivers/intel/soundwire/soundwire.c
index c7e84a533983..f9421fc81c0b 100644
--- a/src/drivers/intel/soundwire/soundwire.c
+++ b/src/drivers/intel/soundwire/soundwire.c
@@ -94,6 +94,6 @@ static void intel_soundwire_enable(struct device *dev)
}
struct chip_operations drivers_intel_soundwire_ops = {
- CHIP_NAME("Intel SoundWire Controller")
+ .name = "Intel SoundWire Controller",
.enable_dev = intel_soundwire_enable
};
diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c
index 7fb600d879b3..970413904b56 100644
--- a/src/drivers/intel/usb4/retimer/retimer.c
+++ b/src/drivers/intel/usb4/retimer/retimer.c
@@ -460,7 +460,7 @@ static void usb4_retimer_enable(struct device *dev)
}
struct chip_operations drivers_intel_usb4_retimer_ops = {
- CHIP_NAME("Intel USB4 Retimer")
+ .name = "Intel USB4 Retimer",
.enable_dev = usb4_retimer_enable
};