summaryrefslogtreecommitdiffstats
path: root/src/drivers/ipmi
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2021-03-15 14:56:16 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-02-16 21:29:53 +0000
commitfff20212afe2c83af90dbec39d112a31d34b6658 (patch)
treeed5d0de6ca1aac63822c479428e1ca63bdf14748 /src/drivers/ipmi
parent97a0d61f0d1d5a9280ba72e2e50d87e4b853777f (diff)
downloadcoreboot-fff20212afe2c83af90dbec39d112a31d34b6658.tar.gz
coreboot-fff20212afe2c83af90dbec39d112a31d34b6658.tar.bz2
coreboot-fff20212afe2c83af90dbec39d112a31d34b6658.zip
Use the fallthrough statement in switch loops
Clang does not seem to work with 'fall through' in comments. Change-Id: Idcbe373be33ef7247548f856bfaba7ceb7f749b5 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51498 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers/ipmi')
-rw-r--r--src/drivers/ipmi/ipmi_kcs_ops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c
index ff187663c904..4ffa91fe2319 100644
--- a/src/drivers/ipmi/ipmi_kcs_ops.c
+++ b/src/drivers/ipmi/ipmi_kcs_ops.c
@@ -247,7 +247,7 @@ ipmi_write_acpi_tables(const struct device *dev, unsigned long current,
break;
default:
printk(BIOS_ERR, "IPMI: Unsupported register spacing for SPMI\n");
- /* fall through */
+ __fallthrough;
case 1:
addr.bit_offset = 8;
break;
@@ -369,7 +369,7 @@ static int ipmi_smbios_data(struct device *dev, int *handle,
break;
default:
printk(BIOS_ERR, "IPMI: Unsupported register spacing for SMBIOS\n");
- /* fall through */
+ __fallthrough;
case 1:
register_spacing = 0 << 6;
break;