diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2021-10-20 20:50:58 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-10-22 01:26:30 +0000 |
| commit | 82faefb339a0853dd49f10bafd2c4f5ca1723fb3 (patch) | |
| tree | f53d53ffb151ab929b32dece690399d3d8e5f4a6 /src/drivers/ocp | |
| parent | 250988d943c322ac1720ae7cd6f88592f82a08c0 (diff) | |
| download | coreboot-82faefb339a0853dd49f10bafd2c4f5ca1723fb3.tar.gz coreboot-82faefb339a0853dd49f10bafd2c4f5ca1723fb3.tar.bz2 coreboot-82faefb339a0853dd49f10bafd2c4f5ca1723fb3.zip | |
cpu/x86/mp_init: use cb_err as status return type in remaining functions
Using cb_err as return type of mp_run_on_aps, mp_run_on_all_aps,
mp_run_on_all_cpus and mp_park_aps clarifies the meaning of the
different return values. This patch also adds the types.h include that
provides the definition of the cb_err enum and checks the return value
of all 4 functions listed above against the enum values instead of
either checking if it's non-zero or less than zero to handle the error
case.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I4b3f03415a041d3ec9cd0e102980e53868b004b0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58494
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/drivers/ocp')
| -rw-r--r-- | src/drivers/ocp/dmi/smbios.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index d0ef11508d64..51c008d4059a 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -11,6 +11,7 @@ #include <soc/soc_util.h> #include <soc/util.h> #include <smbios.h> +#include <types.h> #include "ocp_dmi.h" @@ -244,7 +245,8 @@ void ocp_oem_smbios_strings(struct device *dev, struct smbios_type11 *t) if (CONFIG_MAX_SOCKET == 2 && CONFIG(PARALLEL_MP_AP_WORK)) { /* Read the last CPU MSR */ if (mp_run_on_aps(read_remote_ppin, (void *)&xeon_sp_ppin[1], - get_platform_thread_count() - 1, 100 * USECS_PER_MSEC)) { + get_platform_thread_count() - 1, 100 * USECS_PER_MSEC) != + CB_SUCCESS) { printk(BIOS_ERR, "Failed to read remote PPIN.\n"); t->count = smbios_add_oem_string(t->eos, TBF); } else { |