summaryrefslogtreecommitdiffstats
path: root/src/drivers/uart/uart8250io.c
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-09-11 15:47:09 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-12 14:59:33 +0000
commite3a1247b15e756f01d9c25bc71fa2cf563de34a8 (patch)
treeb5b3757f41355f0e046968f4bdf3c06b51941914 /src/drivers/uart/uart8250io.c
parent8395165eee0ab487993e78de52a63dbc669f6684 (diff)
downloadcoreboot-e3a1247b15e756f01d9c25bc71fa2cf563de34a8.tar.gz
coreboot-e3a1247b15e756f01d9c25bc71fa2cf563de34a8.tar.bz2
coreboot-e3a1247b15e756f01d9c25bc71fa2cf563de34a8.zip
include/console/uart: make index parameter unsigned
The UART index is never negative, so make it unsigned and drop the checks for the index to be non-negative. Change-Id: I64bd60bd2a3b82552cb3ac6524792b9ac6c09a94 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45294 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/drivers/uart/uart8250io.c')
-rw-r--r--src/drivers/uart/uart8250io.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c
index 22b79e8b6b4b..d0841de39c90 100644
--- a/src/drivers/uart/uart8250io.c
+++ b/src/drivers/uart/uart8250io.c
@@ -77,14 +77,14 @@ static void uart8250_init(unsigned int base_port, unsigned int divisor)
static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
-uintptr_t uart_platform_base(int idx)
+uintptr_t uart_platform_base(unsigned int idx)
{
if (idx < ARRAY_SIZE(bases))
return bases[idx];
return 0;
}
-void uart_init(int idx)
+void uart_init(unsigned int idx)
{
if (!CONFIG(DRIVERS_UART_8250IO_SKIP_INIT)) {
unsigned int div;
@@ -94,17 +94,17 @@ void uart_init(int idx)
}
}
-void uart_tx_byte(int idx, unsigned char data)
+void uart_tx_byte(unsigned int idx, unsigned char data)
{
uart8250_tx_byte(uart_platform_base(idx), data);
}
-unsigned char uart_rx_byte(int idx)
+unsigned char uart_rx_byte(unsigned int idx)
{
return uart8250_rx_byte(uart_platform_base(idx));
}
-void uart_tx_flush(int idx)
+void uart_tx_flush(unsigned int idx)
{
uart8250_tx_flush(uart_platform_base(idx));
}