summaryrefslogtreecommitdiffstats
path: root/src/drivers/usb/acpi/usb_acpi.c
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-07-01 01:37:13 -0700
committerFurquan Shaikh <furquan@google.com>2020-07-02 19:12:46 +0000
commitd2d5e44a67f6e7bb80a22822f34397b03426851b (patch)
treea2e74c878fff29047dd6d06e17160f212610b8d2 /src/drivers/usb/acpi/usb_acpi.c
parent7245100cddbef2626cbc208b79c889f8ac642298 (diff)
downloadcoreboot-d2d5e44a67f6e7bb80a22822f34397b03426851b.tar.gz
coreboot-d2d5e44a67f6e7bb80a22822f34397b03426851b.tar.bz2
coreboot-d2d5e44a67f6e7bb80a22822f34397b03426851b.zip
acpi_device: Replace polarity with active_low in acpi_gpio for GpioIo
As per ACPI spec, GpioIo does not have any polarity associated with it. Linux kernel uses `active_low` argument within GPIO _DSD property to allow BIOS to indicate if the corresponding GPIO should be treated as active low. Thus, if GPIO has active high polarity or if it does not have any polarity associated with it, then the `active_low` argument is supposed to be set to 0. Having a `polarity` field in acpi_gpio seems confusing because GPIOs might not always have polarity associated with them. Example, in case of DMIC-select GPIO where 0 means select DMIC0 and 1 means select DMIC1, there is no polarity associated with the GPIO. Thus, it would be clearer for mainboard to use macros without having to specify a particular polarity. In order to enable mainboards to provide GPIO information without polarity for GpioIo usage, this change also adds `ACPI_GPIO_OUTPUT` and `ACPI_GPIO_INPUT` macros. BUG=b:157603026 Change-Id: I39d2a6ac8f149a74afeb915812fece86c9b9ad93 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/42968 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/drivers/usb/acpi/usb_acpi.c')
-rw-r--r--src/drivers/usb/acpi/usb_acpi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c
index e136df0b38ce..d33b7deeaf64 100644
--- a/src/drivers/usb/acpi/usb_acpi.c
+++ b/src/drivers/usb/acpi/usb_acpi.c
@@ -57,7 +57,7 @@ static void usb_acpi_fill_ssdt_generator(const struct device *dev)
dsd = acpi_dp_new_table("_DSD");
acpi_dp_add_gpio(dsd, "reset-gpio", path, 0, 0,
- config->reset_gpio.polarity);
+ config->reset_gpio.active_low);
acpi_dp_write(dsd);
}