diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-07-13 19:08:31 +0200 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2021-07-14 21:26:47 +0000 |
| commit | dd405bc018e3730d0afddfd1cc5f18c6d5fd9794 (patch) | |
| tree | 985c2d19cfc877aaea6e2381b8dd0bf451b14c69 /src/drivers/usb | |
| parent | afab34c3720f673a7edebefe6615ff622253d93e (diff) | |
| download | coreboot-dd405bc018e3730d0afddfd1cc5f18c6d5fd9794.tar.gz coreboot-dd405bc018e3730d0afddfd1cc5f18c6d5fd9794.tar.bz2 coreboot-dd405bc018e3730d0afddfd1cc5f18c6d5fd9794.zip | |
drivers/usb/acpi: Avoid dereferencing maybe-NULL pointer
Do not dereference a pointer before checking whether it is NULL.
Change-Id: Icbe9ae99d91fd587d8e56cf3a0dcb59834ee6d07
Found-by: Coverity CID 1458232
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56266
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/drivers/usb')
| -rw-r--r-- | src/drivers/usb/acpi/usb_acpi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index 8ada93913846..fb9f7f198f52 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -125,12 +125,13 @@ struct chip_operations drivers_usb_acpi_ops = { bool usb_acpi_get_pld(const struct device *usb_device, struct acpi_pld *pld) { - struct drivers_usb_acpi_config *config = usb_device->chip_info; + struct drivers_usb_acpi_config *config; if (!usb_device || !usb_device->chip_info || usb_device->chip_ops != &drivers_usb_acpi_ops) return false; + config = usb_device->chip_info; if (config->use_custom_pld) *pld = config->custom_pld; else |