diff options
| author | Alper Nebi Yasak <alpernebiyasak@gmail.com> | 2023-10-20 22:28:14 +0300 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-02-09 13:41:26 +0000 |
| commit | 8a505902c04b15e20c760f06491b05e05191c594 (patch) | |
| tree | c23722801698ff4cdd316f4dbb385b2287af56e3 /src/drivers | |
| parent | 8facfa84acee18b069a6a6b53491358a7ad1017e (diff) | |
| download | coreboot-8a505902c04b15e20c760f06491b05e05191c594.tar.gz coreboot-8a505902c04b15e20c760f06491b05e05191c594.tar.bz2 coreboot-8a505902c04b15e20c760f06491b05e05191c594.zip | |
drivers/qemu: Drop redundant vga_io addition to ramstage
While introducing driver support for QEMU Cirrus display device, commit
7905f9254ebc ("qemu: cirrus native video init") also explicitly adds
VGA I/O functions into ramstage class when Bochs display driver support
is enabled.
Later, commit db7d04d1b753 ("qemu: Support textmode gfx init.") makes
the related config option select CONFIG_VGA, which also adds the same
file into ramstage class (among other things) in another Makefile.
Doing this twice is unnecessary. Remove the addition based on the Bochs
display driver's config option. Adding it based on CONFIG_VGA is
clearer, and future patches will try to support a Bochs display without
legacy VGA support on non-x86 architectures.
Change-Id: Ib31344e242689682d74d8a83c97b6e8027641926
Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80374
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/drivers')
| -rw-r--r-- | src/drivers/emulation/qemu/Makefile.mk | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/drivers/emulation/qemu/Makefile.mk b/src/drivers/emulation/qemu/Makefile.mk index 6f5ff3a1d67a..c9d94bdca0c2 100644 --- a/src/drivers/emulation/qemu/Makefile.mk +++ b/src/drivers/emulation/qemu/Makefile.mk @@ -7,4 +7,3 @@ ramstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += bochs.c ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += cirrus.c -ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += ../../pc80/vga/vga_io.c |