summaryrefslogtreecommitdiffstats
path: root/src/include/device/pci_ops.h
diff options
context:
space:
mode:
authorTim Wawrzynczak <twawrzynczak@chromium.org>2021-04-29 09:45:59 -0600
committerTim Wawrzynczak <twawrzynczak@chromium.org>2021-05-03 16:28:42 +0000
commit93982c3a6ede0bdb8dd0e94597e4de7b09406947 (patch)
tree8c058b87b2adcd220d41a3530742c67b2426161e /src/include/device/pci_ops.h
parentd87bbde169f84b8c723b0d5289f39df164251b52 (diff)
downloadcoreboot-93982c3a6ede0bdb8dd0e94597e4de7b09406947.tar.gz
coreboot-93982c3a6ede0bdb8dd0e94597e4de7b09406947.tar.bz2
coreboot-93982c3a6ede0bdb8dd0e94597e4de7b09406947.zip
device: Switch pci_dev_is_wake_source to take pci_devfn_t
With the recent switch to SMM module loader v2, the size of the SMM for module google/volteer increased to above 64K in size, and thus failed to install the permanent SMM handler. Turns out, the devicetree is all pulled into the SMM build because of elog, which calls `pci_dev_is_wake_source`, and is the only user of `struct device` in SMM. Changing this function to take a pci_devfn_t instead allows the linker to remove almost the entire devicetree from SMM (only usage left is when disabling HECI via SMM). BUG=b:186661594 TEST=Verify loaded program size of `smm.elf` for google/volteer is almost ~50% smaller. Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Change-Id: I4c39e5188321c8711d6479b15065e5aaedad8f38 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52765 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/include/device/pci_ops.h')
-rw-r--r--src/include/device/pci_ops.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h
index 7fe7d429e2fb..a1678255c451 100644
--- a/src/include/device/pci_ops.h
+++ b/src/include/device/pci_ops.h
@@ -215,6 +215,6 @@ u16 pci_find_capability(const struct device *dev, u16 cap)
*
* Returns true if PCI device is wake source, false otherwise.
*/
-bool pci_dev_is_wake_source(const struct device *dev);
+bool pci_dev_is_wake_source(pci_devfn_t dev);
#endif /* PCI_OPS_H */