diff options
| author | Julius Werner <jwerner@chromium.org> | 2015-09-29 13:51:35 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2016-02-22 21:38:37 +0100 |
| commit | 09f2921b5dacaf79b391652cecd606be4dd69f50 (patch) | |
| tree | 581236de48a22240cb1b823195a79493f037fb64 /src/lib/lzma.c | |
| parent | 0e3d7de7410c4ff7c9465261b58524675a0329e2 (diff) | |
| download | coreboot-09f2921b5dacaf79b391652cecd606be4dd69f50.tar.gz coreboot-09f2921b5dacaf79b391652cecd606be4dd69f50.tar.bz2 coreboot-09f2921b5dacaf79b391652cecd606be4dd69f50.zip | |
cbfs: Add LZ4 in-place decompression support for pre-RAM stages
This patch ports the LZ4 decompression code that debuted in libpayload
last year to coreboot for use in CBFS stages (upgrading the base
algorithm to LZ4's dev branch to access the new in-place decompression
checks). This is especially useful for pre-RAM stages in constrained
SRAM-based systems, which previously could not be compressed due to
the size requirements of the LZMA scratchpad and bounce buffer. The
LZ4 algorithm offers a very lean decompressor function and in-place
decompression support to achieve roughly the same boot speed gains
(trading compression ratio for decompression time) with nearly no
memory overhead.
For now we only activate it for the stages that had previously not been
compressed at all on non-XIP (read: non-x86) boards. In the future we
may also consider replacing LZMA completely for certain boards, since
which algorithm wins out on boot speed depends on board-specific
parameters (architecture, processor speed, SPI transfer rate, etc.).
BRANCH=None
BUG=None
TEST=Built and booted Oak, Jerry, Nyan and Falco. Measured boot time on
Oak to be about ~20ms faster (cutting load times for affected stages
almost in half).
Change-Id: Iec256c0e6d585d1b69985461939884a54e3ab900
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/13638
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/lib/lzma.c')
| -rw-r--r-- | src/lib/lzma.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/lib/lzma.c b/src/lib/lzma.c index 5566cd5dfc96..d0b4c355b16e 100644 --- a/src/lib/lzma.c +++ b/src/lib/lzma.c @@ -29,8 +29,6 @@ size_t ulzman(const void *src, size_t srcn, void *dst, size_t dstn) MAYBE_STATIC unsigned char scratchpad[15980]; const unsigned char *cp; - /* Note: these timestamps aren't useful for memory-mapped media (x86) */ - timestamp_add_now(TS_START_ULZMA); memcpy(properties, src, LZMA_PROPERTIES_SIZE); /* The outSize in LZMA stream is a 64bit integer stored in little-endian * (ref: lzma.cc@LZMACompress: put_64). To prevent accessing by @@ -55,7 +53,6 @@ size_t ulzman(const void *src, size_t srcn, void *dst, size_t dstn) printk(BIOS_WARNING, "lzma: Decoding error = %d\n", res); return 0; } - timestamp_add_now(TS_END_ULZMA); return outProcessed; } |