diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2018-08-27 17:04:53 -0500 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2018-12-19 05:48:13 +0000 |
| commit | a86bbea04d0232132a41acdac8764884d2c4b5f6 (patch) | |
| tree | 927baf72658a7fb7ef77065dd09032b51817153f /src/mainboard/google/cyan/variants/wizpig/gpio.c | |
| parent | 58363b4a3b770eb55e51605dd45d64b8c7e0717c (diff) | |
| download | coreboot-a86bbea04d0232132a41acdac8764884d2c4b5f6.tar.gz coreboot-a86bbea04d0232132a41acdac8764884d2c4b5f6.tar.bz2 coreboot-a86bbea04d0232132a41acdac8764884d2c4b5f6.zip | |
google/cyan: set touchscreen GPIO to non_maskable
Commit 73b723d [google/cyan: Switch Touchpad and Touchscreen...]
in additon to changing the touchpad/touchscreen interrupts from
edge to level triggered, also marked them as maskable. This not only
broke the touchpad functionality, but caused issues with the touchpad
as well. Revert the touchpad to being non_maskable for all cyan
variants with a touchscreen.
Test: boot GalliumOS on google/cyan with a range of kernel versions
(4.15.18, 4.16.13, 4.17.x, 4.18.x) and verify touchscreen functional,
touchpad working properly (not jittery)
Change-Id: I0e0357912f9404af7d0f4e7938a1a94c74810b37
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30236
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard/google/cyan/variants/wizpig/gpio.c')
| -rw-r--r-- | src/mainboard/google/cyan/variants/wizpig/gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/cyan/variants/wizpig/gpio.c b/src/mainboard/google/cyan/variants/wizpig/gpio.c index 3d3b27359ef5..affe8932d464 100644 --- a/src/mainboard/google/cyan/variants/wizpig/gpio.c +++ b/src/mainboard/google/cyan/variants/wizpig/gpio.c @@ -164,7 +164,7 @@ static const struct soc_gpio_map gpn_gpio_map[] = { /* 17 GPIO_SUS3 */ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA), /* 18 GPIO_SUS7 */ - GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA), + GPI(trig_level_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA), /* 19 GPIO_SUS1 */ GPIO_NC, /* 20 GPIO_SUS5 */ GPIO_INPUT_NO_PULL, /* 21 SEC_GPIO_SUS11 */ |