summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google/dedede/romstage.c
diff options
context:
space:
mode:
authorNick Vaccaro <nvaccaro@google.com>2020-09-30 09:49:05 -0700
committerNick Vaccaro <nvaccaro@google.com>2020-10-05 18:02:22 +0000
commit0ed02d00cb129f2aa3959116e1730d4d14da2a60 (patch)
treebea8ca85a8e432f6249fad848ee9cf498446035b /src/mainboard/google/dedede/romstage.c
parentaef9ac97c7b84a5ca51d97d63c4134ffb1da6615 (diff)
downloadcoreboot-0ed02d00cb129f2aa3959116e1730d4d14da2a60.tar.gz
coreboot-0ed02d00cb129f2aa3959116e1730d4d14da2a60.tar.bz2
coreboot-0ed02d00cb129f2aa3959116e1730d4d14da2a60.zip
mb, soc: change mainboard_get_dram_part_num() prototype
Change mainboard_get_dram_part_num() to return a constant character pointer to a null-terminated C string and to take no input parameters. This also addresses the issue that different SOCs and motherboards were using different definitions for mainboard_get_dram_part_num by consolidating to a single definition. BUG=b:169774661, b:168724473 TEST="emerge-volteer coreboot && emerge-dedede coreboot && emerge-hatch coreboot" and verify build completes successfully. Change-Id: Ie7664eab65a2b9e25b7853bf68baf2525b040487 Signed-off-by: Nick Vaccaro <nvaccaro@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45873 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/dedede/romstage.c')
-rw-r--r--src/mainboard/google/dedede/romstage.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c
index 8028db0e6a80..e143f700cd17 100644
--- a/src/mainboard/google/dedede/romstage.c
+++ b/src/mainboard/google/dedede/romstage.c
@@ -22,17 +22,15 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated);
}
-bool mainboard_get_dram_part_num(const char **part_num, size_t *len)
+const char *mainboard_get_dram_part_num(void)
{
static char part_num_store[DIMM_INFO_PART_NUMBER_SIZE];
if (google_chromeec_cbi_get_dram_part_num(&part_num_store[0],
sizeof(part_num_store)) < 0) {
printk(BIOS_ERR, "No DRAM part number in CBI!\n");
- return false;
+ return NULL;
}
- *part_num = &part_num_store[0];
- *len = strlen(part_num_store);
- return true;
+ return part_num_store;
}