summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google/dedede
diff options
context:
space:
mode:
authorReka Norman <rekanorman@chromium.org>2023-09-14 14:29:08 +1000
committerFelix Held <felix-coreboot@felixheld.de>2023-09-15 13:42:23 +0000
commit46b7376e38f2dbf1c04cf91f96e6ae31f17eff50 (patch)
tree40880820f09e7a5b55fc1d4ad8a5a6ff2fc51711 /src/mainboard/google/dedede
parenta56fad6ca8f70169e020d0b76963b1adc32c52f8 (diff)
downloadcoreboot-46b7376e38f2dbf1c04cf91f96e6ae31f17eff50.tar.gz
coreboot-46b7376e38f2dbf1c04cf91f96e6ae31f17eff50.tar.bz2
coreboot-46b7376e38f2dbf1c04cf91f96e6ae31f17eff50.zip
mb/google/dedede/var/dibbi: Swap USB3 ports for A2 and A3
BUG=b:264960828 TEST=USB2 and USB3 ports are peered correctly in the kernel: Before: $ cd /sys/devices/pci0000:00/0000:00:14.0 $ ls -l $(find . -name peer) ./usb1/1-0:1.0/usb1-port1/peer -> ../../../usb2/2-0:1.0/usb2-port1 ./usb1/1-0:1.0/usb1-port2/peer -> ../../../usb2/2-0:1.0/usb2-port3 ./usb1/1-0:1.0/usb1-port3/peer -> ../../../usb2/2-0:1.0/usb2-port4 ./usb1/1-0:1.0/usb1-port4/peer -> ../../../usb2/2-0:1.0/usb2-port5 ./usb1/1-0:1.0/usb1-port5/peer -> ../../../usb2/2-0:1.0/usb2-port6 ./usb2/2-0:1.0/usb2-port1/peer -> ../../../usb1/1-0:1.0/usb1-port1 ./usb2/2-0:1.0/usb2-port3/peer -> ../../../usb1/1-0:1.0/usb1-port2 ./usb2/2-0:1.0/usb2-port4/peer -> ../../../usb1/1-0:1.0/usb1-port3 ./usb2/2-0:1.0/usb2-port5/peer -> ../../../usb1/1-0:1.0/usb1-port4 ./usb2/2-0:1.0/usb2-port6/peer -> ../../../usb1/1-0:1.0/usb1-port5 After: $ cd /sys/devices/pci0000:00/0000:00:14.0 $ ls -l $(find . -name peer) ./usb1/1-0:1.0/usb1-port1/peer -> ../../../usb2/2-0:1.0/usb2-port1 ./usb1/1-0:1.0/usb1-port2/peer -> ../../../usb2/2-0:1.0/usb2-port3 ./usb1/1-0:1.0/usb1-port3/peer -> ../../../usb2/2-0:1.0/usb2-port4 ./usb1/1-0:1.0/usb1-port4/peer -> ../../../usb2/2-0:1.0/usb2-port6 ./usb1/1-0:1.0/usb1-port5/peer -> ../../../usb2/2-0:1.0/usb2-port5 ./usb2/2-0:1.0/usb2-port1/peer -> ../../../usb1/1-0:1.0/usb1-port1 ./usb2/2-0:1.0/usb2-port3/peer -> ../../../usb1/1-0:1.0/usb1-port2 ./usb2/2-0:1.0/usb2-port4/peer -> ../../../usb1/1-0:1.0/usb1-port3 ./usb2/2-0:1.0/usb2-port5/peer -> ../../../usb1/1-0:1.0/usb1-port5 ./usb2/2-0:1.0/usb2-port6/peer -> ../../../usb1/1-0:1.0/usb1-port4 Change-Id: I5fe8066e361da62b747464b2ec09bcc6e7dda0fe Signed-off-by: Reka Norman <rekanorman@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77867 Reviewed-by: Sam McNally <sammc@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Diffstat (limited to 'src/mainboard/google/dedede')
-rw-r--r--src/mainboard/google/dedede/variants/dibbi/overridetree.cb9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/mainboard/google/dedede/variants/dibbi/overridetree.cb b/src/mainboard/google/dedede/variants/dibbi/overridetree.cb
index 6cda5862af8f..5bc127dc5882 100644
--- a/src/mainboard/google/dedede/variants/dibbi/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/dibbi/overridetree.cb
@@ -166,7 +166,6 @@ chip soc/intel/jasperlake
end # SA Thermal device
device pci 14.0 on
chip drivers/usb/acpi
- # TODO (b/264960828) verify PLD values
device usb 0.0 on
chip drivers/usb/acpi
register "desc" = ""USB2 Type-C Port C0""
@@ -220,15 +219,15 @@ chip soc/intel/jasperlake
device usb 3.3 on end
end
chip drivers/usb/acpi
- register "desc" = ""USB3 Type-A Port A2""
+ register "desc" = ""USB3 Type-A Port A3""
register "type" = "UPC_TYPE_USB3_A"
- register "group" = "ACPI_PLD_GROUP(1, 4)"
+ register "group" = "ACPI_PLD_GROUP(1, 5)"
device usb 3.4 on end
end
chip drivers/usb/acpi
- register "desc" = ""USB3 Type-A Port A3""
+ register "desc" = ""USB3 Type-A Port A2""
register "type" = "UPC_TYPE_USB3_A"
- register "group" = "ACPI_PLD_GROUP(1, 5)"
+ register "group" = "ACPI_PLD_GROUP(1, 4)"
device usb 3.5 on end
end
end