summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google/herobrine
diff options
context:
space:
mode:
authorRavi Kumar Bokka <rbokka@codeaurora.org>2022-02-08 14:38:03 +0530
committerShelley Chen <shchen@google.com>2022-02-17 22:43:28 +0000
commitca7c9cc3f282c0833f98fc155250237db05dcf5f (patch)
tree77ee22d77936f09e81cc5285b452067a11ba599d /src/mainboard/google/herobrine
parente1d6f5b80d58cf6a87b69d95477e2dfe3889a6e3 (diff)
downloadcoreboot-ca7c9cc3f282c0833f98fc155250237db05dcf5f.tar.gz
coreboot-ca7c9cc3f282c0833f98fc155250237db05dcf5f.tar.bz2
coreboot-ca7c9cc3f282c0833f98fc155250237db05dcf5f.zip
mb/google/herobrine: Disable fingerprint sensor on CRD devices
Qualcomm CRD devices do not have a fingerprint sensor so removing the QUP configuration for it. This QUP also coincidentally is the same as the one used for the TPM, so this initially was also causing TPM communication issues during bootup as the QUP was being reconfigured during the later stages after QcLib execution. BUG=b:206581077 BRANCH=None TEST=Boot to kernel without any CR50 communication errors Signed-off-by: Ravi Kumar Bokka <rbokka@codeaurora.org> Change-Id: I8d13b67796b70b0b7e9a4721cca0b8a54b2b27c1 Signed-off-by: Shelley Chen <shchen@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61716 Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/herobrine')
-rw-r--r--src/mainboard/google/herobrine/mainboard.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c
index 092a20296fa1..362dff57157d 100644
--- a/src/mainboard/google/herobrine/mainboard.c
+++ b/src/mainboard/google/herobrine/mainboard.c
@@ -83,8 +83,6 @@ static void mainboard_init(struct device *dev)
qupv3_se_fw_load_and_init(QUPV3_0_SE1, SE_PROTOCOL_I2C, GSI);
/* ESIM SPI */
qupv3_se_fw_load_and_init(QUPV3_1_SE4, SE_PROTOCOL_SPI, MIXED);
- /* Fingerprint SPI */
- qupv3_se_fw_load_and_init(QUPV3_1_SE6, SE_PROTOCOL_SPI, MIXED);
} else {
/* Trackpad I2C */
qupv3_se_fw_load_and_init(QUPV3_0_SE0, SE_PROTOCOL_I2C, MIXED);