diff options
author | Subrata Banik <subratabanik@google.com> | 2023-02-22 10:22:03 +0000 |
---|---|---|
committer | Subrata Banik <subratabanik@google.com> | 2023-02-22 11:02:29 +0000 |
commit | 9ac47c871f75dd17e27892293c7b94e4691631d0 (patch) | |
tree | 9724bfd25eab96e45991c2ae45c319e8c958abb2 /src/mainboard/google/poppy/variants/nami/mainboard.c | |
parent | fb660c35b507e6d7775c0647bc267d0294bf172d (diff) | |
download | coreboot-9ac47c871f75dd17e27892293c7b94e4691631d0.tar.gz coreboot-9ac47c871f75dd17e27892293c7b94e4691631d0.tar.bz2 coreboot-9ac47c871f75dd17e27892293c7b94e4691631d0.zip |
Revert "mb/google/poppy: Nami - invoke power cycle of FPMCU on startup"
This reverts commit 2e6fa8206e0a3bdd2e53542b6377fe2b37e3f26e.
Reason for revert: causing `redefinition` issue.
src/mainboard/google/poppy/variants/nami/gpio.c:527:26: error: redefinition of 'variant_romstage_gpio_table'
const struct pad_config *variant_romstage_gpio_table(size_t *num)
^
src/mainboard/google/poppy/variants/nami/gpio.c:426:26: note: previous definition is here
const struct pad_config *variant_romstage_gpio_table(size_t *num)
^
Change-Id: I107cce8bf3a5bf38edb39b9d46512ee0d467d354
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73210
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/google/poppy/variants/nami/mainboard.c')
-rw-r--r-- | src/mainboard/google/poppy/variants/nami/mainboard.c | 35 |
1 files changed, 0 insertions, 35 deletions
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index a4634fc6e50d..b703d40fc3c2 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -15,8 +15,6 @@ #include <soc/ramstage.h> #include <string.h> #include <variant/sku.h> -#include <gpio.h> -#include <delay.h> #define PL2_I7_SKU 44 #define PL2_DEFAULT 29 @@ -301,36 +299,3 @@ void variant_devtree_update(void) sku_overwrite_mapping[oem_index].dc_loadline[i]; } } - -void variant_final(void) -{ - uint32_t sku_id = variant_board_sku(); - - switch (sku_id) { - case SKU_0_BARD: - case SKU_1_BARD: - case SKU_2_BARD: - case SKU_3_BARD: - case SKU_4_BARD: - case SKU_5_BARD: - case SKU_6_BARD: - case SKU_7_BARD: - case SKU_0_EKKO: - case SKU_1_EKKO: - case SKU_2_EKKO: - case SKU_3_EKKO: - case SKU_4_EKKO: - case SKU_5_EKKO: - case SKU_6_EKKO: - case SKU_7_EKKO: - /* Enable FPMCU late in the boot process to achieve - * ~150ms of power off time in total. - */ - gpio_output(GPP_B11, 1); /* PCH_FP_PWR_EN */ - mdelay(3); - gpio_output(GPP_C9, 1); /* FP_RST_ODL */ - break; - default: - break; - } -} |