summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google/skyrim/variants
diff options
context:
space:
mode:
authorJohn Su <john_su@compal.corp-partner.google.com>2023-04-20 14:35:35 +0800
committerMartin Roth <martin.roth@amd.corp-partner.google.com>2023-04-21 15:53:40 +0000
commitfa7e6b8c031702a2ad31018fb00dfa75e427cbb7 (patch)
tree90fb14320662b8ed5998eed1985c9ad0957c940d /src/mainboard/google/skyrim/variants
parentfb74b3e037ac27e7575abb8a5a87c38013daf037 (diff)
downloadcoreboot-fa7e6b8c031702a2ad31018fb00dfa75e427cbb7.tar.gz
coreboot-fa7e6b8c031702a2ad31018fb00dfa75e427cbb7.tar.bz2
coreboot-fa7e6b8c031702a2ad31018fb00dfa75e427cbb7.zip
mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
Because WD SSD drive isn't holding the clock low for some reason. So we change to read eMMC clkreq signal instead. BRANCH=none BUG=b:278495684 TEST=emerge-skyrim coreboot chromeos-bootimage and verify ok. Signed-off-by: John Su <john_su@compal.corp-partner.google.com> Change-Id: I3a9225473a6ae1ba01dc8e5d982c4999f073267e Reviewed-on: https://review.coreboot.org/c/coreboot/+/74583 Reviewed-by: Chao Gui <chaogui@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
Diffstat (limited to 'src/mainboard/google/skyrim/variants')
-rw-r--r--src/mainboard/google/skyrim/variants/markarth/port_descriptors.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/google/skyrim/variants/markarth/port_descriptors.c b/src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
index 330fc46a926d..94eb465edfce 100644
--- a/src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
+++ b/src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
@@ -74,7 +74,7 @@ static const fsp_dxio_descriptor nvme_dxio_descriptors[] = {
},
};
-#define NVME_CLKREQ_GPIO 92
+#define EMMC_CLKREQ_GPIO 115
void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num)
{
/*
@@ -85,13 +85,13 @@ void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t
* This allows checking the state of the NVMe device clkreq signal and enabling
* either eMMC or NVMe based on that.
*/
- if (gpio_get(NVME_CLKREQ_GPIO)) {
- printk(BIOS_DEBUG, "Enabling eMMC.\n");
- *dxio_num = ARRAY_SIZE(emmc_dxio_descriptors);
- *dxio_descs = emmc_dxio_descriptors;
- } else {
+ if (gpio_get(EMMC_CLKREQ_GPIO)) {
printk(BIOS_DEBUG, "Enabling NVMe.\n");
*dxio_num = ARRAY_SIZE(nvme_dxio_descriptors);
*dxio_descs = nvme_dxio_descriptors;
+ } else {
+ printk(BIOS_DEBUG, "Enabling eMMC.\n");
+ *dxio_num = ARRAY_SIZE(emmc_dxio_descriptors);
+ *dxio_descs = emmc_dxio_descriptors;
}
}