summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google/skyrim
diff options
context:
space:
mode:
authorZheng Bao <fishbaozi@gmail.com>2023-02-14 13:26:31 +0800
committerFelix Held <felix-coreboot@felixheld.de>2023-09-01 11:47:15 +0000
commit6bc06983ed1d6c545056b584eabc2f7864cb39cd (patch)
tree85e01a12ae0de1e768747bc3760ff9300faf517e /src/mainboard/google/skyrim
parentd0de6c2183af5f6c435e53632fe92793be4d3783 (diff)
downloadcoreboot-6bc06983ed1d6c545056b584eabc2f7864cb39cd.tar.gz
coreboot-6bc06983ed1d6c545056b584eabc2f7864cb39cd.tar.bz2
coreboot-6bc06983ed1d6c545056b584eabc2f7864cb39cd.zip
util/amdfwtool: Deal with psp position in flash offset directly
It is based on work by Arthur Heymans, 69852. Get rid of the confusing "position index" and use the relative flash offset as the Kconfig setting instead. TEST=binary identical on amd/birman amd/majolica amd/gardenia amd/mayan amd/bilby amd/mandolin amd/chausie amd/pademelon pcengines/apu2 google/skyrim google/guybrush google/zork google/kahlee google/myst (The test should be done with INCLUDE_CONFIG_FILE=n) Change-Id: I26bde0b7c70efe9f5762109f431329ea7f95b7f2 Signed-off-by: Zheng Bao <fishbaozi@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/72939 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/mainboard/google/skyrim')
-rw-r--r--src/mainboard/google/skyrim/Kconfig5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig
index dc681e8701b4..44ecfc4699e9 100644
--- a/src/mainboard/google/skyrim/Kconfig
+++ b/src/mainboard/google/skyrim/Kconfig
@@ -5,10 +5,6 @@ config BOARD_GOOGLE_BASEBOARD_SKYRIM
if BOARD_GOOGLE_BASEBOARD_SKYRIM
-config AMD_FWM_POSITION_INDEX
- int
- default 3
-
config BOARD_SPECIFIC_OPTIONS
def_bool y
select ACPI_S1_NOT_SUPPORTED
@@ -49,6 +45,7 @@ config BOARD_SPECIFIC_OPTIONS
select PCIEXP_CLK_PM
select PCIEXP_COMMON_CLOCK
select PCIEXP_L1_SUB_STATE
+ select AMD_FWM_POSITION_C20000_DEFAULT
config DEVICETREE
default "variants/baseboard/devicetree.cb"