summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google/stout
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-11-02 18:16:32 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2022-04-06 09:21:46 +0000
commite50bb8fc9efe25edf1ab27c7b6a88dfb7293ce06 (patch)
tree3151a5fc6969f68e027f005f2a58ae2367ac7ba0 /src/mainboard/google/stout
parent487d04540b551f2b3253b6f9042c723e5472023f (diff)
downloadcoreboot-e50bb8fc9efe25edf1ab27c7b6a88dfb7293ce06.tar.gz
coreboot-e50bb8fc9efe25edf1ab27c7b6a88dfb7293ce06.tar.bz2
coreboot-e50bb8fc9efe25edf1ab27c7b6a88dfb7293ce06.zip
ChromeOS: Add legacy mainboard_ec_running_ro()
Motivation is to have mainboard_chromeos_acpi_generate() do nothing else than fill ACPI \OIPG package. Change-Id: I3cb95268424dc27f8c1e26b3d34eff1a7b8eab7f Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58896 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/mainboard/google/stout')
-rw-r--r--src/mainboard/google/stout/chromeos.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/mainboard/google/stout/chromeos.c b/src/mainboard/google/stout/chromeos.c
index 964217e8f1f5..fcbbc8aee0da 100644
--- a/src/mainboard/google/stout/chromeos.c
+++ b/src/mainboard/google/stout/chromeos.c
@@ -49,8 +49,7 @@ int get_lid_switch(void)
* The recovery-switch is virtual on Stout and is handled via the EC.
* Stout recovery mode is only valid if RTC_PWR_STS is set and the EC
* indicated the recovery keys were pressed. We use a global flag for
- * rec_mode to be used after RTC_POWER_STS has been cleared. This function
- * is complicated by romstage support, which can't use a global variable.
+ * rec_mode to be used after RTC_POWER_STS has been cleared.
* Note, rec_mode is the only time the EC is in RO mode, otherwise, RW.
*/
int get_recovery_mode_switch(void)
@@ -75,6 +74,11 @@ int get_recovery_mode_switch(void)
return ec_in_rec_mode;
}
+bool mainboard_ec_running_ro(void)
+{
+ return !!get_recovery_mode_switch();
+}
+
static const struct cros_gpio cros_gpios[] = {
CROS_GPIO_REC_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
CROS_GPIO_WP_AL(GPIO_SPI_WP, CROS_GPIO_DEVICE_NAME),
@@ -82,8 +86,5 @@ static const struct cros_gpio cros_gpios[] = {
void mainboard_chromeos_acpi_generate(void)
{
- if (CONFIG(CHROMEOS_NVS) && !get_recovery_mode_switch())
- chromeos_set_ecfw_rw();
-
chromeos_acpi_gpio_generate(cros_gpios, ARRAY_SIZE(cros_gpios));
}