diff options
| author | Julius Werner <jwerner@chromium.org> | 2021-08-10 14:29:29 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2021-08-16 22:54:45 +0000 |
| commit | ac330b371498b7f6f89e80a182409595c2db4a05 (patch) | |
| tree | 5d2e43938283dc88773e55794eae79e66d48bfe4 /src/mainboard/google/trogdor/chromeos.c | |
| parent | 25fc070e35d45d8988a88ef1e22de60cd4041563 (diff) | |
| download | coreboot-ac330b371498b7f6f89e80a182409595c2db4a05.tar.gz coreboot-ac330b371498b7f6f89e80a182409595c2db4a05.tar.bz2 coreboot-ac330b371498b7f6f89e80a182409595c2db4a05.zip | |
trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
"Latched" GPIOs like this one are a virtual representation of the
pending interrupt flag for the edge-triggered pin and not a direct
representation of line state, so they should always be marked
ACTIVE_HIGH or depthcharge will incorrectly negate them. This has always
been wrong and meant that depthcharge doesn't correctly wait for Cr50
flow control responses on these platforms. Thankfully it doesn't seem
like we've seen any practical issues from this, but it's still very
wrong.
BRANCH=trogdor
BUG=none
TEST=Booted CoachZ (no visible difference)
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56901
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Diffstat (limited to 'src/mainboard/google/trogdor/chromeos.c')
| -rw-r--r-- | src/mainboard/google/trogdor/chromeos.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index 2136da32e159..c2183880cef5 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -31,7 +31,7 @@ void fill_lb_gpios(struct lb_gpios *gpios) "EC in RW"}, {GPIO_AP_EC_INT.addr, ACTIVE_LOW, gpio_get(GPIO_AP_EC_INT), "EC interrupt"}, - {GPIO_H1_AP_INT.addr, ACTIVE_LOW, gpio_get(GPIO_H1_AP_INT), + {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT), "TPM interrupt"}, {GPIO_SD_CD_L.addr, ACTIVE_LOW, gpio_get(GPIO_SD_CD_L), "SD card detect"}, |