diff options
| author | Venkat Thogaru <quic_thogaru@quicinc.com> | 2022-09-07 17:17:39 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-13 13:05:46 +0000 |
| commit | fec9abc697006a9d374cefe84a037db2d9dc9c88 (patch) | |
| tree | ad755530210d17c518aa8936183dda27ae277040 /src/mainboard/google/trogdor | |
| parent | bec412156af23603289e56944bcda2df94af15e9 (diff) | |
| download | coreboot-fec9abc697006a9d374cefe84a037db2d9dc9c88.tar.gz coreboot-fec9abc697006a9d374cefe84a037db2d9dc9c88.tar.bz2 coreboot-fec9abc697006a9d374cefe84a037db2d9dc9c88.zip | |
sc7180: Fix DDR training failure during warm reset with OTA
Problem: OTA is triggering warmboot, where DDR is
in self-refresh mode. Due to which DDR training
is not going well.
Change: Verify reboot type in case of OTA. If it is warmboot, will
force for cold boot inorder to trigger DDR training
BUG=b:236990316
TEST=Validated on qualcomm sc7180 development board.
Test observation: Cold boot is triggered forcefully,
if current reboot is warmboot in case of OTA
Signed-off-by: Venkat Thogaru <quic_thogaru@quicinc.com>
Change-Id: I908370662292d9f768d1ac89452775178e07fc78
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67406
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/trogdor')
| -rw-r--r-- | src/mainboard/google/trogdor/Makefile.inc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/mainboard/google/trogdor/Makefile.inc b/src/mainboard/google/trogdor/Makefile.inc index 9a71ea5197be..16afd03234fc 100644 --- a/src/mainboard/google/trogdor/Makefile.inc +++ b/src/mainboard/google/trogdor/Makefile.inc @@ -13,6 +13,9 @@ verstage-y += chromeos.c romstage-y += romstage.c romstage-y += boardid.c romstage-y += chromeos.c +ifneq ($(CONFIG_BOARD_GOOGLE_BUBS),y) +romstage-y += reset.c +endif ramstage-y += mainboard.c ifneq ($(CONFIG_BOARD_GOOGLE_BUBS),y) |