diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-09-11 15:43:45 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2020-09-15 03:57:43 +0000 |
| commit | b0334e13babfa79ac6733d87c22fb93ef620a003 (patch) | |
| tree | ce951316ad284a1f90cc1ce4fdf4b354e060ad50 /src/mainboard/google/zork/variants/berknip | |
| parent | 5ed3cb99ac838c43ab96f44f11685f56e041716c (diff) | |
| download | coreboot-b0334e13babfa79ac6733d87c22fb93ef620a003.tar.gz coreboot-b0334e13babfa79ac6733d87c22fb93ef620a003.tar.bz2 coreboot-b0334e13babfa79ac6733d87c22fb93ef620a003.zip | |
mb/google/zork: Fix FPMCU_INT_L configuration
Fingerprint interrupt (FPMCU_INT_L) is level triggered and not edge
triggered. Also, we are using GEVENT for wake from fingerprint and
not the GPIO IRQ wake. Thus, the irq property exposed in ACPI tables
does not need to be set to indicate wake for the IRQ.
This change updates GPIO table to configure the pad as level triggered
and drops the wake attribute for irq_gpio in overridetree.
BUG=b:165612778
BRANCH=zork
TEST=Verified that fingerprint still works in S0 and to wake device
from S3.
Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: I9007e5b0882ac1a6770db52d651218998f6d750d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45307
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard/google/zork/variants/berknip')
| -rw-r--r-- | src/mainboard/google/zork/variants/berknip/overridetree.cb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index 9797b469fa96..868db9b8a080 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -109,7 +109,7 @@ chip soc/amd/picasso register "desc" = ""Fingerprint Reader"" register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""google,cros-ec-uart"" - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW_WAKE(GPIO_6)" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_6)" register "wake" = "GEVENT_10" register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" device generic 0 on end |