diff options
| author | Karthikeyan Ramasubramanian <kramasub@google.com> | 2020-11-10 14:36:31 -0700 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2020-11-13 01:28:14 +0000 |
| commit | 132e969ca86aa6343d9f388be0f8dc7d8251b1e4 (patch) | |
| tree | 07acf971d8ef0b4dd02e6e90570ac1c9f5ae4f61 /src/mainboard/google/zork/variants/vilboz/overridetree.cb | |
| parent | 62e957d0296c3f4ce7682300272f223796a782ee (diff) | |
| download | coreboot-132e969ca86aa6343d9f388be0f8dc7d8251b1e4.tar.gz coreboot-132e969ca86aa6343d9f388be0f8dc7d8251b1e4.tar.bz2 coreboot-132e969ca86aa6343d9f388be0f8dc7d8251b1e4.zip | |
mb/google/zork: Configure IRQs as level triggered for HID over I2C
As per HID over I2C Protocol Specification[1] Version 1.00 Section 7.4,
the interrupt line used by the device is required to be level triggered.
Hence, this change updates the configuration of the HID over I2C devices
to be level triggered.
References:
[1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d96d5b/hid-over-i2c-protocol-spec-v1-0.docx
BUG=b:172846122
TEST=./util/abuild/abuild
Change-Id: I75a92616f11054993ff5a5bfefce5c3f4638c07c
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47420
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/google/zork/variants/vilboz/overridetree.cb')
| -rw-r--r-- | src/mainboard/google/zork/variants/vilboz/overridetree.cb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 2f3b4fcc4e83..3b3bdd4c7efc 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -100,7 +100,7 @@ chip soc/amd/picasso chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_12)" register "generic.probed" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)" register "generic.enable_delay_ms" = "10" @@ -153,7 +153,7 @@ chip soc/amd/picasso chip drivers/i2c/hid register "generic.hid" = ""PNP0C50"" register "generic.desc" = ""Synaptics Touchpad"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_9)" register "generic.wake" = "GEVENT_22" register "generic.probed" = "1" register "hid_desc_reg_offset" = "0x20" |