diff options
| author | xuxinxiong <xuxinxiong@huaqin.corp-partner.google.com> | 2021-03-26 22:53:35 +0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-04-06 07:04:00 +0000 |
| commit | 3ced5287f2f9fe0904dce377e0bf5720df8c1a53 (patch) | |
| tree | c1a3aee3e3339da7cf2f07397efe42f504f06a7b /src/mainboard/google | |
| parent | f14705153545819b1a134e8c6f33f38190b75c70 (diff) | |
| download | coreboot-3ced5287f2f9fe0904dce377e0bf5720df8c1a53.tar.gz coreboot-3ced5287f2f9fe0904dce377e0bf5720df8c1a53.tar.bz2 coreboot-3ced5287f2f9fe0904dce377e0bf5720df8c1a53.zip | |
mb/google/kukui: fix the issue of getting error panel_id
Current get panel_id is over sku_id() >> 4, but sku_id is combined with
wfc_id/lcm_id/sku_id, so the panel_id value is wfc_id << 4 | lcm_id()
in fact. When wfc_id is not 0, the panel_id will be wrong. So only get
the low 4 bits for the panel_id.
BUG=b:183779755
BRANCH=kukui
TEST=emerge-kukui
Change-Id: I63e0c8a2719462a9b979afe52a27c78b9fc804e8
Signed-off-by: Tao Xia <xiatao5@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51853
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/kukui/mainboard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index fbdf63320c1a..893d94db430a 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -124,7 +124,7 @@ struct panel_description *get_panel_from_cbfs(struct panel_description *desc) static struct panel_description *get_active_panel(void) { /* TODO(hungte) Create a dedicated panel_id() in board_id.c */ - int panel_id = sku_id() >> 4; + int panel_id = sku_id() >> 4 & 0x0F; struct panel_description *panel = get_panel_description(panel_id); if (!panel) { |