diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2023-07-28 09:32:07 -0500 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@gmail.com> | 2023-08-05 16:01:09 +0000 |
| commit | 94ad304451c42c79b1a1fab5ede822aba40a909f (patch) | |
| tree | 151233dbd9b00f05448cdbc696fadc11e33299b4 /src/mainboard/google | |
| parent | 1b67362971c3e09cb4771043424fe205ceb3b52b (diff) | |
| download | coreboot-94ad304451c42c79b1a1fab5ede822aba40a909f.tar.gz coreboot-94ad304451c42c79b1a1fab5ede822aba40a909f.tar.bz2 coreboot-94ad304451c42c79b1a1fab5ede822aba40a909f.zip | |
mb/google/rambi: Fix built-in audio under Windows
Move the jack detect GpioInt resources under the codec (where they
belong), but also leave a copy under LPEA for since the Linux drivers
(incorrectly) require them there. Add pin list for Windows' SST driver.
Adapted from the Intel ValleyView edk2 ACPI reference code.
TEST=build/boot Win11, Linux on google/swanky; verify audio functional
OOTB under Linux, under Windows with coolstar's drivers.
Change-Id: I51c07013fc20f07d2fd3639f7fbc2af0e0e490a0
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76795
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: CoolStar <coolstarorganization@gmail.com>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/rambi/acpi/mainboard.asl | 20 |
1 files changed, 16 insertions, 4 deletions
diff --git a/src/mainboard/google/rambi/acpi/mainboard.asl b/src/mainboard/google/rambi/acpi/mainboard.asl index bfbb66bf801b..5f835e851799 100644 --- a/src/mainboard/google/rambi/acpi/mainboard.asl +++ b/src/mainboard/google/rambi/acpi/mainboard.asl @@ -89,6 +89,9 @@ Scope (\_SB.PCI0.I2C2) { BOARD_CODEC_IRQ } + GpioIo (Exclusive, PullNone, 0, 0, , "\\_SB.GPSC", 0, ResourceConsumer, ,){ 0x000E } + + GpioIo (Exclusive, PullNone, 0, 0, , "\\_SB.GPSC", 0, ResourceConsumer, ,){ 0x000F } }) Method (_STA) @@ -107,13 +110,22 @@ Scope (\_SB.PCI0.LPEA) Name (GBUF, ResourceTemplate () { /* Jack Detect (index 0) */ - GpioInt (Level, ActiveHigh, Exclusive, PullNone,, - "\\_SB.GPSC") { 14 } + GpioIo (Exclusive, PullNone, 0, 0, , "\\_SB.GPSC", 0, ResourceConsumer, ,){ 0x000E } /* Mic Detect (index 1) */ - GpioInt (Level, ActiveHigh, Exclusive, PullNone,, - "\\_SB.GPSC") { 15 } + GpioIo (Exclusive, PullNone, 0, 0, , "\\_SB.GPSC", 0, ResourceConsumer, ,){ 0x000F } + + /* SST Wants This */ + GpioInt (Edge, ActiveHigh, Exclusive, PullNone, 0x0000, + "\\_SB.GPSS", 0x00, ResourceConsumer, ,) + { + 0x001C // Pin list + } }) + Method (_DIS, 0x0, NotSerialized) + { + //Add a dummy disable function + } } #include <variant/acpi/mainboard.asl> |