summaryrefslogtreecommitdiffstats
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorDtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>2022-04-15 14:28:17 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-04-19 13:06:14 +0000
commitf17f6d9334ac8b6f3e74abaab6270cf22a70aa3c (patch)
tree324704ecd2a0dc95b351242fbbd3c892f535de76 /src/mainboard/google
parent4b642fd512e6c28bbce2fe97b882ba2c9742ea59 (diff)
downloadcoreboot-f17f6d9334ac8b6f3e74abaab6270cf22a70aa3c.tar.gz
coreboot-f17f6d9334ac8b6f3e74abaab6270cf22a70aa3c.tar.bz2
coreboot-f17f6d9334ac8b6f3e74abaab6270cf22a70aa3c.zip
mb/google/brask: fix boot beep
Fix the issue that can't hear the boot beep at dev screen. GPP_B14 is used for PWM_PP3300_BUZZER and it should set to GPO. Modify GPP_B14 from PAD_CFG_NF_LOCK to PAD_CFG_GPO_LOCK. BUG=b:229345416 BRANCH=firmware-brya-14505.B TEST=emerge-brask coreboot and verify if the buzzer beeps. Signed-off-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Change-Id: I601735ab20974cd992ca5dd6dbaca1517a395aa2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63645 Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brask/gpio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c
index 93f5393d93db..e81bd05942a4 100644
--- a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c
+++ b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c
@@ -80,7 +80,7 @@ static const struct pad_config gpio_table[] = {
/* B13 : PLTRST# ==> PLT_RST_L */
PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1),
/* B14 : SPKR ==> PWM_PP3300_BUZZER */
- PAD_CFG_NF_LOCK(GPP_B14, NONE, NF1, LOCK_CONFIG),
+ PAD_CFG_GPO_LOCK(GPP_B14, 0, LOCK_CONFIG),
/* B15 : TIME_SYNC0 ==> TP159 */
PAD_NC_LOCK(GPP_B15, NONE, LOCK_CONFIG),
/* B16 : I2C5_SDA ==> NC */