diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2022-05-16 12:27:36 +0200 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-05-28 04:17:47 +0000 |
| commit | 8d3640d22610eeb9a21c803d75c698e681a1dc62 (patch) | |
| tree | d544c971843f5b5c60dfe6efbdf456d6d701494c /src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c | |
| parent | 74782cb2f4601f5b67c6b169a7ab9b1d0778c638 (diff) | |
| download | coreboot-8d3640d22610eeb9a21c803d75c698e681a1dc62.tar.gz coreboot-8d3640d22610eeb9a21c803d75c698e681a1dc62.tar.bz2 coreboot-8d3640d22610eeb9a21c803d75c698e681a1dc62.zip | |
vendorcode/amd/agesa/f15tn: Fix all improper use of .data
AGESA has a lot of code in the .data section which is for initialized
data, that in fact should be .rodata. This adds the 'CONST' keyword
everywhere it is needed.
TEST: See in the .elf file (e.g. using readelf) that there is nothing in
.data section.
Change-Id: I9593c24f764319f66a64715d91175f64edf10608
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64386
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c')
| -rw-r--r-- | src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c index a3553c0dc787..377e39016b09 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c @@ -71,7 +71,7 @@ #define PULL_DOWN (PullDown | PullUpB) #define PULL_NONE (PullUpB) -GPIO_CONTROL pavilion_m6_1035dx_gpio[] = { +CONST GPIO_CONTROL pavilion_m6_1035dx_gpio[] = { {57, Function1, OUTPUT_HIGH | PULL_NONE}, /* WLAN enable */ {-1} }; @@ -87,7 +87,7 @@ GPIO_CONTROL pavilion_m6_1035dx_gpio[] = { #define SCI_MAP_XHCI_10_0 0x78 #define SCI_MAP_PWRBTN 0x73 -SCI_MAP_CONTROL m6_1035dx_sci_map[] = { +CONST SCI_MAP_CONTROL m6_1035dx_sci_map[] = { {GEVENT_PIN(EC_SCI_GEVENT), EC_SCI_GPE}, {GEVENT_PIN(EC_LID_GEVENT), EC_LID_GPE}, {GEVENT_PIN(PCIE_GEVENT), PCIE_GPE}, |