summaryrefslogtreecommitdiffstats
path: root/src/mainboard/lenovo/x200
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2021-02-28 15:23:59 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-02 12:17:14 +0000
commit3173f857b63afaa4b4d4119311db7f6fb9191d09 (patch)
tree7ade8d700e20a9eb1efa2a76a97b0e8007a5cd84 /src/mainboard/lenovo/x200
parent1037e341233a7ac87dbaf9e2544571b892a3262c (diff)
downloadcoreboot-3173f857b63afaa4b4d4119311db7f6fb9191d09.tar.gz
coreboot-3173f857b63afaa4b4d4119311db7f6fb9191d09.tar.bz2
coreboot-3173f857b63afaa4b4d4119311db7f6fb9191d09.zip
mb/lenovo/x200: Fix docking events
Even though `device` entries are children of `chip` entries in the devicetree source format, the chips in the translated C structures are only hooked up to device nodes. Hence, to configure a chip in a device- or overridetree, it always needs a `device` below it. This should fix docking events for the X200 ThinkPad. Change-Id: I561e7ae81f2e096a091868ce51daa1c8f66af067 Signed-off-by: Nico Huber <nico.h@gmx.de> Found-by: Kevin Keijzer <kevin@quietlife.nl> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51118 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Kevin Keijzer Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/lenovo/x200')
-rw-r--r--src/mainboard/lenovo/x200/variants/x200/overridetree.cb1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mainboard/lenovo/x200/variants/x200/overridetree.cb b/src/mainboard/lenovo/x200/variants/x200/overridetree.cb
index dd08f1f5155f..51beecc89726 100644
--- a/src/mainboard/lenovo/x200/variants/x200/overridetree.cb
+++ b/src/mainboard/lenovo/x200/variants/x200/overridetree.cb
@@ -16,6 +16,7 @@ chip northbridge/intel/gm45
device pci 1f.0 on # LPC bridge
chip ec/lenovo/pmh7
+ device pnp ff.1 on end # dummy
register "dock_event_enable" = "0x01"
end
chip superio/nsc/pc87382