summaryrefslogtreecommitdiffstats
path: root/src/mainboard/lenovo
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2022-12-02 19:16:21 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2022-12-07 11:33:38 +0000
commit521e0460e4292ff0bdaad4ca3861603d13ccfe1d (patch)
treed0f50fdf75599471abca42603c6a1f21f348cfb6 /src/mainboard/lenovo
parent2c3ebd8b9d56c01d8e4adadf6f4e4d5b56cdb4e1 (diff)
downloadcoreboot-521e0460e4292ff0bdaad4ca3861603d13ccfe1d.tar.gz
coreboot-521e0460e4292ff0bdaad4ca3861603d13ccfe1d.tar.bz2
coreboot-521e0460e4292ff0bdaad4ca3861603d13ccfe1d.zip
sb,soc/intel,mb: Drop leftover comments and TODOs in ASL
Change-Id: I74f943e9b616458a16aa13c29706cf1551fcbbb2 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70366 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/lenovo')
-rw-r--r--src/mainboard/lenovo/t400/acpi/platform.asl32
-rw-r--r--src/mainboard/lenovo/t60/acpi/platform.asl27
-rw-r--r--src/mainboard/lenovo/x200/acpi/platform.asl32
-rw-r--r--src/mainboard/lenovo/x201/acpi/platform.asl7
-rw-r--r--src/mainboard/lenovo/x60/acpi/platform.asl27
5 files changed, 0 insertions, 125 deletions
diff --git a/src/mainboard/lenovo/t400/acpi/platform.asl b/src/mainboard/lenovo/t400/acpi/platform.asl
index 3d2805d19f62..08ea6aef2b89 100644
--- a/src/mainboard/lenovo/t400/acpi/platform.asl
+++ b/src/mainboard/lenovo/t400/acpi/platform.asl
@@ -6,8 +6,6 @@
Method(_PTS,1)
{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
\_SB.PCI0.LPCB.EC.MUTE(1)
\_SB.PCI0.LPCB.EC.USBP(0)
\_SB.PCI0.LPCB.EC.RADI(0)
@@ -20,26 +18,6 @@ Method(_WAK,1)
/* Wake the HKEY to init BT/WWAN */
\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- // TODO: Return Arg0 as second value if S-Arg0 was entered
- // before.
-
Return(Package(){0,0})
}
@@ -52,16 +30,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
\GOS()
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
}
}
diff --git a/src/mainboard/lenovo/t60/acpi/platform.asl b/src/mainboard/lenovo/t60/acpi/platform.asl
index 50da033b2d4a..08ea6aef2b89 100644
--- a/src/mainboard/lenovo/t60/acpi/platform.asl
+++ b/src/mainboard/lenovo/t60/acpi/platform.asl
@@ -18,23 +18,6 @@ Method(_WAK,1)
/* Wake the HKEY to init BT/WWAN */
\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (Arg0 == 3) {
- // ..
- }
-
- // Are we going to S4?
- If (Arg0 == 4) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
Return(Package(){0,0})
}
@@ -47,16 +30,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
\GOS()
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
}
}
diff --git a/src/mainboard/lenovo/x200/acpi/platform.asl b/src/mainboard/lenovo/x200/acpi/platform.asl
index aa2924870431..08ea6aef2b89 100644
--- a/src/mainboard/lenovo/x200/acpi/platform.asl
+++ b/src/mainboard/lenovo/x200/acpi/platform.asl
@@ -6,8 +6,6 @@
Method(_PTS,1)
{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
\_SB.PCI0.LPCB.EC.MUTE(1)
\_SB.PCI0.LPCB.EC.USBP(0)
\_SB.PCI0.LPCB.EC.RADI(0)
@@ -20,26 +18,6 @@ Method(_WAK,1)
/* Wake the HKEY to init BT/WWAN */
\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (Arg0 == 3) {
- // ..
- }
-
- // Are we going to S4?
- If (Arg0 == 4) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- // TODO: Return Arg0 as second value if S-Arg0 was entered
- // before.
-
Return(Package(){0,0})
}
@@ -52,16 +30,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
\GOS()
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
}
}
diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl
index 44b06c6a05db..f17adafc883c 100644
--- a/src/mainboard/lenovo/x201/acpi/platform.asl
+++ b/src/mainboard/lenovo/x201/acpi/platform.asl
@@ -35,13 +35,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- /* TRAP(71) */ /* TODO */
-
/* Determine the Operating System and save the value in OSYS.
* We have to do this in order to be able to work around
* certain windows bugs.
diff --git a/src/mainboard/lenovo/x60/acpi/platform.asl b/src/mainboard/lenovo/x60/acpi/platform.asl
index 50da033b2d4a..08ea6aef2b89 100644
--- a/src/mainboard/lenovo/x60/acpi/platform.asl
+++ b/src/mainboard/lenovo/x60/acpi/platform.asl
@@ -18,23 +18,6 @@ Method(_WAK,1)
/* Wake the HKEY to init BT/WWAN */
\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (Arg0 == 3) {
- // ..
- }
-
- // Are we going to S4?
- If (Arg0 == 4) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
Return(Package(){0,0})
}
@@ -47,16 +30,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
\GOS()
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
}
}