diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2019-06-15 19:00:17 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-06-21 08:44:24 +0000 |
| commit | c82d7e76d5583c89434a57553fefa6ba8f464c73 (patch) | |
| tree | 817ff7dda606fcbc449eed933528c39976017946 /src/mainboard/lenovo | |
| parent | 2c0ecc1f83dd1dee808d4ebfdfb1525fc9d1d529 (diff) | |
| download | coreboot-c82d7e76d5583c89434a57553fefa6ba8f464c73.tar.gz coreboot-c82d7e76d5583c89434a57553fefa6ba8f464c73.tar.bz2 coreboot-c82d7e76d5583c89434a57553fefa6ba8f464c73.zip | |
mb/lenovo/x201/smihandler.c: Remove useless smihandler code
This code to handle the brightness from SMM is copied from the Lenovo
Thinkpad X60 code, but does not work on later generation. The PCI
device it tries to address does not even exist on those devices.
Change-Id: I0c25c3e5bec651b27158a84cc91289639a04ceb6
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33508
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/mainboard/lenovo')
| -rw-r--r-- | src/mainboard/lenovo/x201/smihandler.c | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/src/mainboard/lenovo/x201/smihandler.c b/src/mainboard/lenovo/x201/smihandler.c index 9043f8e18c42..e80782acf682 100644 --- a/src/mainboard/lenovo/x201/smihandler.c +++ b/src/mainboard/lenovo/x201/smihandler.c @@ -15,7 +15,6 @@ */ #include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <southbridge/intel/ibexpeak/nvs.h> @@ -71,23 +70,6 @@ int mainboard_io_trap_handler(int smif) return 1; } -static void mainboard_smi_brightness_up(void) -{ - u8 value; - - if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0) - pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf); -} - -static void mainboard_smi_brightness_down(void) -{ - u8 value; - - if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10) - pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, - (value - 0x10) & 0xf0); -} - static void mainboard_smi_handle_ec_sci(void) { u8 status = inb(EC_SC); @@ -100,14 +82,6 @@ static void mainboard_smi_handle_ec_sci(void) printk(BIOS_DEBUG, "EC event %02x\n", event); switch (event) { - case 0x14: - /* brightness up */ - mainboard_smi_brightness_up(); - break; - case 0x15: - /* brightness down */ - mainboard_smi_brightness_down(); - break; case 0x18: /* Fn-F9 key */ case 0x27: |