Revert "mb/pcengines/apu2: add reset logic for PCIe slots"

This reverts commit c04871a398ca945b42fde0867572094c38f6f92c.

Reason for revert: Many apu2 users reported issues with PCIe modules
detection in mPCIe2 slot (4x GFX PCIe). The regression was not caught
by 3mdeb validation stands and hardware configuration.

Change-Id: I609bf4b27c88a9adf676d576169f5ca26726ee86
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40147
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

1 files changed, 0 insertions, 71 deletions

diff --git a/src/mainboard/pcengines/apu2/BiosCallOuts.c b/src/mainboard/pcengines/apu2/BiosCallOuts.c
index d61402b4ac9b..7af4e67542ed 100644
--- a/src/mainboard/pcengines/apu2/BiosCallOuts.c
+++ b/src/mainboard/pcengines/apu2/BiosCallOuts.c
@@ -2,7 +2,6 @@
 /* This file is part of the coreboot project. */
 
 #include <AGESA.h>
-#include <amdblocks/acpimmio.h>
 #include <console/console.h>
 #include <spd_bin.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
@@ -14,7 +13,6 @@
 #include "hudson.h"
 
 static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr);
-static AGESA_STATUS board_GnbPciExSlotReset(UINT32 Func, UINTN Data, VOID *ConfigPtr);
 
 const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
@@ -23,7 +21,6 @@ const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 	{AGESA_READ_SPD_RECOVERY,        agesa_NoopUnsupported },
 	{AGESA_RUNFUNC_ONAP,             agesa_RunFuncOnAp },
 	{AGESA_GET_IDS_INIT_DATA,        agesa_EmptyIdsInitData },
-	{AGESA_GNB_PCIE_SLOT_RESET,      board_GnbPciExSlotReset },
 	{AGESA_HOOKBEFORE_DQS_TRAINING,  agesa_NoopSuccess },
 	{AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopSuccess }
 };
@@ -131,71 +128,3 @@ static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *Confi
 
 	return AGESA_SUCCESS;
 }
-
-/* PCIE slot reset control */
-static AGESA_STATUS board_GnbPciExSlotReset(UINT32 Func, UINTN Data, VOID *ConfigPtr)
-{
-	AGESA_STATUS		Status;
-	PCIe_SLOT_RESET_INFO	*ResetInfo;
-	uint32_t		GpioData;
-	uint8_t			GpioValue;
-
-	ResetInfo = ConfigPtr;
-	Status = AGESA_UNSUPPORTED;
-
-	switch (ResetInfo->ResetId) {
-	/*
-	 * ResetID 1 = PCIE_RST# affects all PCIe slots on all boards except
-	 * apu2. ResetID 1 does not need any GPIO.
-	 */
-	case 1:
-		Status = AGESA_SUCCESS;
-		break;
-	case 51: /* GPIO51 resets mPCIe1 slot on apu2 */
-		switch (ResetInfo->ResetControl) {
-		case AssertSlotReset:
-			GpioData = gpio1_read32(0x8);
-			printk(BIOS_DEBUG, "%s: ResetID %u assert %08x\n",
-				__func__, ResetInfo->ResetId, GpioData);
-			GpioValue = gpio1_read8(0xa);
-			GpioValue &= ~BIT6;
-			gpio1_write8(0xa, GpioValue);
-			Status = AGESA_SUCCESS;
-			break;
-		case DeassertSlotReset:
-			GpioData = gpio1_read32(0x8);
-			printk(BIOS_DEBUG, "%s: ResetID %u deassert %08x\n",
-				__func__, ResetInfo->ResetId, GpioData);
-			GpioValue = gpio1_read8(0xa);
-			GpioValue |= BIT6;
-			gpio1_write8(0xa, GpioValue);
-			Status = AGESA_SUCCESS;
-			break;
-		}
-		break;
-	case 55: /* GPIO51 resets mPCIe2 slot on apu2 */
-		switch (ResetInfo->ResetControl) {
-		case AssertSlotReset:
-			GpioData = gpio1_read32(0xc);
-			printk(BIOS_DEBUG, "%s: ResetID %u assert %08x\n",
-				__func__, ResetInfo->ResetId, GpioData);
-			GpioValue = gpio1_read8(0xe);
-			GpioValue &= ~BIT6;
-			gpio1_write8(0xa, GpioValue);
-			Status = AGESA_SUCCESS;
-			break;
-		case DeassertSlotReset:
-			GpioData = gpio1_read32(0xc);
-			printk(BIOS_DEBUG, "%s: ResetID %u deassert %08x\n",
-				__func__, ResetInfo->ResetId, GpioData);
-			GpioValue = gpio1_read8(0xe);
-			GpioValue |= BIT6;
-			gpio1_write8(0xa, GpioValue);
-			Status = AGESA_SUCCESS;
-			break;
-		}
-		break;
-	}
-
-	return Status;
-}