diff options
| author | Matt DeVillier <matt.devillier@puri.sm> | 2019-07-23 16:47:05 -0500 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2019-07-25 16:41:32 +0000 |
| commit | ea244146050e2ea12fd4f9ed1c44693daaac082a (patch) | |
| tree | 17c677be170d80abc06801fcdb12957c9be82c55 /src/mainboard/purism/librem_skl/Kconfig | |
| parent | cd92979d4486377591f59c9e4de984211f9b30fd (diff) | |
| download | coreboot-ea244146050e2ea12fd4f9ed1c44693daaac082a.tar.gz coreboot-ea244146050e2ea12fd4f9ed1c44693daaac082a.tar.bz2 coreboot-ea244146050e2ea12fd4f9ed1c44693daaac082a.zip | |
mb/purism/librem_skl: use SOC_INTEL_COMMON_BLOCK_HDA_VERB
Remove old hda_verb.c code copied from intel/kblrvp7, as it's
been superseded by the common block HDA implementation.
Fixes a null pointer error preventing the HDA codecs from being
initialized, as found in Coverity CID 1403651.
Test: build/boot Librem 13v2, verify functional audio
Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
Change-Id: I2fd5363aad027f215f93964bc6a85f00fea86c88
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34531
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/purism/librem_skl/Kconfig')
| -rw-r--r-- | src/mainboard/purism/librem_skl/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 2372b9d28005..ecde9e4774d6 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -5,6 +5,7 @@ config BOARD_PURISM_BASEBOARD_LIBREM_SKL select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_LPSS_UART_FOR_CONSOLE + select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_SKYLAKE select MAINBOARD_USES_FSP2_0 select SPD_READ_BY_WORD |