diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2012-04-30 14:57:51 -0700 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2012-05-01 19:27:34 +0200 |
| commit | e6063fee5c954d5acd80fd51e11aeac31e83d13d (patch) | |
| tree | 331b26df9de6e8b4e08473432de1d293602487df /src/mainboard/samsung/lumpy/acpi_tables.c | |
| parent | a1155b47ca42ad1813c36e1d6de6e8116ae13845 (diff) | |
| download | coreboot-e6063fee5c954d5acd80fd51e11aeac31e83d13d.tar.gz coreboot-e6063fee5c954d5acd80fd51e11aeac31e83d13d.tar.bz2 coreboot-e6063fee5c954d5acd80fd51e11aeac31e83d13d.zip | |
Fix Sandybridge/Ivybridge mainboards according to code review
This fixes a few cosmetics with the following three boards:
- Intel Emerald Lake 2
- Samsung ChromeBook
- Samsung ChromeBox
The following issues were fixed:
- rely on include path in ASL code instead of specifying relative
paths
- use updated ALIGN_CURRENT in acpi_tables.c
- use preprocessor defines instead of hard coded values where possible
Change-Id: Ia5941be3873aa84c30c13ff2f0428d1c52daa563
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/963
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/mainboard/samsung/lumpy/acpi_tables.c')
| -rw-r--r-- | src/mainboard/samsung/lumpy/acpi_tables.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c index a9eeb74664ef..46fdf315ce0c 100644 --- a/src/mainboard/samsung/lumpy/acpi_tables.c +++ b/src/mainboard/samsung/lumpy/acpi_tables.c @@ -177,7 +177,7 @@ unsigned long acpi_fill_srat(unsigned long current) void smm_setup_structures(void *gnvs, void *tcg, void *smi1); -#define ALIGN_CURRENT current = ((current + 0x0f) & -0x10) +#define ALIGN_CURRENT current = (ALIGN(current, 16)) unsigned long write_acpi_tables(unsigned long start) { unsigned long current; |