diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-06-13 15:57:06 +0300 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-12-23 21:18:25 +0000 |
| commit | ff01bca624283ba149c90a32d8f5655f27749a85 (patch) | |
| tree | 9f4a2acbcd62ea69b726b0034808ade61f1b4483 /src/mainboard/samsung | |
| parent | ad489b8a2719e85933e21b14dede0a7f5833bcf9 (diff) | |
| download | coreboot-ff01bca624283ba149c90a32d8f5655f27749a85.tar.gz coreboot-ff01bca624283ba149c90a32d8f5655f27749a85.tar.bz2 coreboot-ff01bca624283ba149c90a32d8f5655f27749a85.zip | |
ChromeOS: Refactor ACPI CNVS generation
Remove chromeos_dsdt_generator() calls under mainboard, it
is possible to make the single call to fill \CNVS and
\OIPG without leveraging device operations.
Change-Id: Id79af96bb6c038d273ac9c4afc723437fc1f3fc9
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55502
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/samsung')
| -rw-r--r-- | src/mainboard/samsung/lumpy/mainboard.c | 2 | ||||
| -rw-r--r-- | src/mainboard/samsung/stumpy/mainboard.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/samsung/lumpy/mainboard.c b/src/mainboard/samsung/lumpy/mainboard.c index d804b2b9749f..9bf3b96e655d 100644 --- a/src/mainboard/samsung/lumpy/mainboard.c +++ b/src/mainboard/samsung/lumpy/mainboard.c @@ -10,7 +10,6 @@ #include "onboard.h" #include <southbridge/intel/bd82x6x/pch.h> #include <smbios.h> -#include <vendorcode/google/chromeos/chromeos.h> void mainboard_suspend_resume(void) { @@ -73,7 +72,6 @@ static void mainboard_enable(struct device *dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = lumpy_onboard_smbios_data; - dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); } diff --git a/src/mainboard/samsung/stumpy/mainboard.c b/src/mainboard/samsung/stumpy/mainboard.c index 6291d60993eb..3b6727b0576a 100644 --- a/src/mainboard/samsung/stumpy/mainboard.c +++ b/src/mainboard/samsung/stumpy/mainboard.c @@ -4,14 +4,12 @@ #include <drivers/intel/gma/int15.h> #include <acpi/acpi.h> #include <southbridge/intel/bd82x6x/pch.h> -#include <vendorcode/google/chromeos/chromeos.h> // mainboard_enable is executed as first thing after // enumerate_buses(). static void mainboard_enable(struct device *dev) { - dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); } |