diff options
| author | Mario Scheithauer <mario.scheithauer@siemens.com> | 2023-06-27 15:22:55 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-07-03 12:47:45 +0000 |
| commit | dfdb5a05b49cfa7562b59b8ba6949ba6392da612 (patch) | |
| tree | 4d3dd2db0705dc3f11d12347da56c94f41ed2e46 /src/mainboard/siemens/mc_apl1 | |
| parent | 19fc004e9a107d841696626721ed89e8943a6920 (diff) | |
| download | coreboot-dfdb5a05b49cfa7562b59b8ba6949ba6392da612.tar.gz coreboot-dfdb5a05b49cfa7562b59b8ba6949ba6392da612.tar.bz2 coreboot-dfdb5a05b49cfa7562b59b8ba6949ba6392da612.zip | |
mb/siemens/{mc_apl3,mc_apl5,mc_apl6}: Remove TX_DWORD3 macro
A correction of Tx signal from SATA interface is not necessary on these
boards currently. Therefore remove the define and the corresponding code
on mc_apl5.
Change-Id: I5092ee128cb35e126069d18bb3cbd635e01bbcdb
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76173
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jan Samek <jan.samek@siemens.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Diffstat (limited to 'src/mainboard/siemens/mc_apl1')
3 files changed, 0 insertions, 11 deletions
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c index c17f1be4116d..b61f32df49ce 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c @@ -14,8 +14,6 @@ #include <baseboard/variants.h> #include <types.h> -#define TX_DWORD3 0xa8c - void variant_mainboard_final(void) { struct device *dev = NULL; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c index 7362a486d0c1..1e7fa37cf876 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c @@ -13,8 +13,6 @@ #include <baseboard/variants.h> #include <types.h> -#define TX_DWORD3 0xa8c - void variant_mainboard_final(void) { struct device *dev = NULL; @@ -34,11 +32,6 @@ void variant_mainboard_final(void) */ pcr_or32(PID_LPC, PCR_LPC_PRC, (PCR_LPC_CCE_EN | PCR_LPC_PCE_EN)); - /* Correct the SATA transmit signal via the High Speed I/O Transmit Control Register 3. - Bit [23:16] set the output voltage swing for TX line. The value 0x4a sets the swing - level to 0.58 V. */ - pcr_rmw32(PID_MODPHY, TX_DWORD3, (0x00 << 16), (0x4a << 16)); - /* Set Master Enable for on-board PCI device if allowed. */ dev = dev_find_device(PCI_VID_SIEMENS, 0x403e, 0); if (dev) { diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c index b5aa068d34b5..1856a35b3c93 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c @@ -14,8 +14,6 @@ #include <baseboard/variants.h> #include <types.h> -#define TX_DWORD3 0xa8c - void variant_mainboard_final(void) { struct device *dev = NULL; |