diff options
| author | Felix Singer <felixsinger@posteo.net> | 2022-12-26 08:39:35 +0100 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2022-12-27 09:04:02 +0000 |
| commit | dfbb634ae16065811894d67ff802c1e838ce0749 (patch) | |
| tree | 0ad779089e19231a8e1c279ab40b3c9f195a680f /src/mainboard/system76 | |
| parent | ca4b587f95c0f1ed64e187511781abdfd4c7ebfb (diff) | |
| download | coreboot-dfbb634ae16065811894d67ff802c1e838ce0749.tar.gz coreboot-dfbb634ae16065811894d67ff802c1e838ce0749.tar.bz2 coreboot-dfbb634ae16065811894d67ff802c1e838ce0749.zip | |
mainboard/acpi: Replace constant "One" with actual number
Change-Id: Id1078b14a805eea53d2a7c5a8183a5413f26e115
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71521
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/system76')
| -rw-r--r-- | src/mainboard/system76/kbl-u/acpi/ac.asl | 2 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/acpi/battery.asl | 6 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/acpi/ec.asl | 2 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/acpi/hid.asl | 6 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/acpi/lid.asl | 2 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/acpi/s76.asl | 2 |
6 files changed, 10 insertions, 10 deletions
diff --git a/src/mainboard/system76/kbl-u/acpi/ac.asl b/src/mainboard/system76/kbl-u/acpi/ac.asl index 73266761980b..b417e03c53ff 100644 --- a/src/mainboard/system76/kbl-u/acpi/ac.asl +++ b/src/mainboard/system76/kbl-u/acpi/ac.asl @@ -8,7 +8,7 @@ Device (AC) _SB }) - Name (ACFG, One) + Name (ACFG, 1) Method (_PSR, 0, NotSerialized) // _PSR: Power Source { diff --git a/src/mainboard/system76/kbl-u/acpi/battery.asl b/src/mainboard/system76/kbl-u/acpi/battery.asl index f3a8a9adb75b..ec1ef3126534 100644 --- a/src/mainboard/system76/kbl-u/acpi/battery.asl +++ b/src/mainboard/system76/kbl-u/acpi/battery.asl @@ -30,10 +30,10 @@ Device (BAT0) Name (PBIF, Package (0x0D) { - One, // 0 - Power Unit + 1, // 0 - Power Unit 0xFFFFFFFF, // 1 - Design Capacity 0xFFFFFFFF, // 2 - Last Full Charge Capacity - One, // 3 - Battery Technology + 1, // 3 - Battery Technology 0x39D0, // 4 - Design Voltage Zero, // 5 - Design Capacity of Warning Zero, // 6 - Design Capacity of Low @@ -127,7 +127,7 @@ Device (BAT0) } Else { - Local0 |= One + Local0 |= 1 Local1 = (^^PCI0.LPCB.EC0.BPR0 & 0xFFFF) } diff --git a/src/mainboard/system76/kbl-u/acpi/ec.asl b/src/mainboard/system76/kbl-u/acpi/ec.asl index de25eca12904..ff31c01c9ca7 100644 --- a/src/mainboard/system76/kbl-u/acpi/ec.asl +++ b/src/mainboard/system76/kbl-u/acpi/ec.asl @@ -26,7 +26,7 @@ Device (EC0) Method (_REG, 2, Serialized) // _REG: Region Availability { Debug = Concatenate("EC: _REG", Concatenate(ToHexString(Arg0), Concatenate(" ", ToHexString(Arg1)))) - If ((Arg0 == 0x03) && (Arg1 == One)) { + If ((Arg0 == 0x03) && (Arg1 == 1)) { // Enable hardware touchpad lock, airplane mode, and keyboard backlight keys ECOS = 1 diff --git a/src/mainboard/system76/kbl-u/acpi/hid.asl b/src/mainboard/system76/kbl-u/acpi/hid.asl index 6610c2e1bc2c..8bbb65bc45f1 100644 --- a/src/mainboard/system76/kbl-u/acpi/hid.asl +++ b/src/mainboard/system76/kbl-u/acpi/hid.asl @@ -25,7 +25,7 @@ Device (HIDD) Method (HPEM, 1, Serialized) { - HBSY = One + HBSY = 1 HIDX = Arg0 Notify (HIDD, 0xC0) @@ -36,11 +36,11 @@ Device (HIDD) Local0++ } - If (HBSY == One) + If (HBSY == 1) { HBSY = Zero HIDX = Zero - Return (One) + Return (1) } Else { diff --git a/src/mainboard/system76/kbl-u/acpi/lid.asl b/src/mainboard/system76/kbl-u/acpi/lid.asl index 582c38d87c14..067c96f32b09 100644 --- a/src/mainboard/system76/kbl-u/acpi/lid.asl +++ b/src/mainboard/system76/kbl-u/acpi/lid.asl @@ -10,7 +10,7 @@ Device (LID0) If (^^PCI0.LPCB.EC0.ECOK) { Return (^^PCI0.LPCB.EC0.LSTE) } Else { - Return (One) + Return (1) } } diff --git a/src/mainboard/system76/kbl-u/acpi/s76.asl b/src/mainboard/system76/kbl-u/acpi/s76.asl index 399e56973426..c4f7837e691d 100644 --- a/src/mainboard/system76/kbl-u/acpi/s76.asl +++ b/src/mainboard/system76/kbl-u/acpi/s76.asl @@ -65,7 +65,7 @@ Device (S76D) { Method (GKBL, 0, Serialized) { Local0 = 0 If (^^PCI0.LPCB.EC0.ECOK) { - ^^PCI0.LPCB.EC0.FDAT = One + ^^PCI0.LPCB.EC0.FDAT = 1 ^^PCI0.LPCB.EC0.FCMD = 0xCA Local0 = ^^PCI0.LPCB.EC0.FBUF ^^PCI0.LPCB.EC0.FCMD = Zero |