summaryrefslogtreecommitdiffstats
path: root/src/mainboard
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2021-12-05 02:40:26 +0100
committerFelix Singer <felixsinger@posteo.net>2021-12-09 21:52:13 +0000
commit715b787fd3d1a0e714da795ea3d3eaf28ca49577 (patch)
tree36bddb19913ef007da7ba6d4aa29758e21ca189f /src/mainboard
parent2bf2e6d1ccd87cdd8d9c189972eae89e47e542c8 (diff)
downloadcoreboot-715b787fd3d1a0e714da795ea3d3eaf28ca49577.tar.gz
coreboot-715b787fd3d1a0e714da795ea3d3eaf28ca49577.tar.bz2
coreboot-715b787fd3d1a0e714da795ea3d3eaf28ca49577.zip
soc/intel/tigerlake: Hook up SMBus device to devicetree
Hook up `SmbusEnable` FSP setting to devicetree state and drop its redundant devicetree setting `SmbusEnable`. The following mainboards enable the SMBus device in the devicetree despite `SmbusEnable` is not being set. * google/deltaur * starlabs/laptop Thus, set it to off to keep the current state unchanged. Change-Id: I0789af20beb147fc1a6a7d046cdcea15cb44ce4c Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59883 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/deltaur/variants/baseboard/devicetree.cb2
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/devicetree.cb1
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb1
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb1
-rw-r--r--src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb2
-rw-r--r--src/mainboard/system76/darp7/devicetree.cb4
-rw-r--r--src/mainboard/system76/galp5/devicetree.cb4
-rw-r--r--src/mainboard/system76/gaze16/devicetree.cb4
-rw-r--r--src/mainboard/system76/lemp10/devicetree.cb4
-rw-r--r--src/mainboard/system76/oryp8/devicetree.cb1
10 files changed, 6 insertions, 18 deletions
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
index 72ed789aec67..9ed8fb299e46 100644
--- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb
@@ -291,7 +291,7 @@ chip soc/intel/tigerlake
device pci 1f.1 off end # P2SB
device pci 1f.2 hidden end # PMC
device pci 1f.3 on end # Intel HDA
- device pci 1f.4 on end # SMBus
+ device pci 1f.4 off end # SMBus
device pci 1f.5 on end # PCH SPI Flash Controller
device pci 1f.6 off end # GbE Controller
device pci 1f.7 off end # Intel Trace Hub
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index b4c4f6a41fe8..eee29ef2cee0 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -92,7 +92,6 @@ chip soc/intel/tigerlake
# FSP configuration
register "SaGv" = "SaGv_Enabled"
- register "SmbusEnable" = "0"
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0
register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A1
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index b84fddc397b5..0e34eb266391 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -13,7 +13,6 @@ chip soc/intel/tigerlake
# FSP configuration
register "SaGv" = "SaGv_Enabled"
- register "SmbusEnable" = "1"
# CNVi BT enable/disable
register "CnviBtCore" = "true"
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index fcadcee990bf..17af01aaebfb 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -13,7 +13,6 @@ chip soc/intel/tigerlake
# FSP configuration
register "SaGv" = "SaGv_Disabled"
- register "SmbusEnable" = "1"
# CNVi BT enable/disable
register "CnviBtCore" = "true"
diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb
index 5c55dce396a1..c8abce9be734 100644
--- a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb
+++ b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb
@@ -232,7 +232,7 @@ chip soc/intel/tigerlake
subsystemid 0x10ec 0x1200
register "PchHdaAudioLinkHdaEnable" = "1"
end
- device pci 1f.4 on end # SMBus
+ device pci 1f.4 off end # SMBus
device pci 1f.5 on end # PCH SPI
device pci 1f.6 off end # GbE
device pci 1f.7 off end # TH
diff --git a/src/mainboard/system76/darp7/devicetree.cb b/src/mainboard/system76/darp7/devicetree.cb
index 8c16d2addb5c..7a3e072236e9 100644
--- a/src/mainboard/system76/darp7/devicetree.cb
+++ b/src/mainboard/system76/darp7/devicetree.cb
@@ -329,9 +329,7 @@ chip soc/intel/tigerlake
device ref hda on
register "PchHdaAudioLinkHdaEnable" = "1"
end
- device ref smbus on
- register "SmbusEnable" = "1"
- end
+ device ref smbus on end
device ref fast_spi on end
end
end
diff --git a/src/mainboard/system76/galp5/devicetree.cb b/src/mainboard/system76/galp5/devicetree.cb
index b0fa5243fb6a..aabeedbf6bf6 100644
--- a/src/mainboard/system76/galp5/devicetree.cb
+++ b/src/mainboard/system76/galp5/devicetree.cb
@@ -333,9 +333,7 @@ chip soc/intel/tigerlake
device ref hda on
register "PchHdaAudioLinkHdaEnable" = "1"
end
- device ref smbus on
- register "SmbusEnable" = "1"
- end
+ device ref smbus on end
device ref fast_spi on end
end
end
diff --git a/src/mainboard/system76/gaze16/devicetree.cb b/src/mainboard/system76/gaze16/devicetree.cb
index 380bdc0c0f81..f5f216cc4b6a 100644
--- a/src/mainboard/system76/gaze16/devicetree.cb
+++ b/src/mainboard/system76/gaze16/devicetree.cb
@@ -145,9 +145,7 @@ chip soc/intel/tigerlake
device ref hda on
register "PchHdaAudioLinkHdaEnable" = "1"
end
- device ref smbus on
- register "SmbusEnable" = "1"
- end
+ device ref smbus on end
device ref fast_spi on end
end
end
diff --git a/src/mainboard/system76/lemp10/devicetree.cb b/src/mainboard/system76/lemp10/devicetree.cb
index 5c702b9fe19f..2c03e60d81fd 100644
--- a/src/mainboard/system76/lemp10/devicetree.cb
+++ b/src/mainboard/system76/lemp10/devicetree.cb
@@ -294,9 +294,7 @@ chip soc/intel/tigerlake
device ref hda on
register "PchHdaAudioLinkHdaEnable" = "1"
end
- device ref smbus on
- register "SmbusEnable" = "1"
- end
+ device ref smbus on end
device ref fast_spi on end
end
end
diff --git a/src/mainboard/system76/oryp8/devicetree.cb b/src/mainboard/system76/oryp8/devicetree.cb
index 429ad621c4ff..4263806b344a 100644
--- a/src/mainboard/system76/oryp8/devicetree.cb
+++ b/src/mainboard/system76/oryp8/devicetree.cb
@@ -212,7 +212,6 @@ chip soc/intel/tigerlake
register "PchHdaAudioLinkHdaEnable" = "1"
end
device ref smbus on
- register "SmbusEnable" = "1"
chip drivers/i2c/tas5825m
register "id" = "0"
device i2c 4e on end # (8bit address: 0x9c)